From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11356 Path: news.gmane.org!.POSTED!not-for-mail From: Samuel Holland Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] fix fchown fallback on arches without chown(2) Date: Sat, 27 May 2017 15:20:01 -0500 Message-ID: <20170527202001.27170-1-samuel@sholland.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1495916427 15619 195.159.176.226 (27 May 2017 20:20:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 May 2017 20:20:27 +0000 (UTC) Cc: Samuel Holland To: musl@lists.openwall.com Original-X-From: musl-return-11371-gllmg-musl=m.gmane.org@lists.openwall.com Sat May 27 22:20:22 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1dEiCE-0003uG-CQ for gllmg-musl@m.gmane.org; Sat, 27 May 2017 22:20:22 +0200 Original-Received: (qmail 24471 invoked by uid 550); 27 May 2017 20:20:25 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 24433 invoked from network); 27 May 2017 20:20:23 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:date:from:message-id:subject:to:x-me-sender:x-me-sender :x-sasl-enc:x-sasl-enc; s=fm1; bh=ML3LV4VHsCLLba750jBGQAAHjHKbtL 74tr0YZbJOhtE=; b=ucvIpF1QzkazWZLiMXcdiXA+6HZzO3EZxhxKk2ECtSMz0E nykteg+TXCm13trb0qeVi3R0ENE3QjgNOXGUFaYpAI2htn800rDVcOYc0ETMxUCd mo1+tfu0mU4+ciaccVGdhRFGppAvHw+gB+1o4WGzR5epRsnNX+0nPswv7Ii2NwPC S/8GAATr1s4RltzRQHA0ek2FGAOuHgWkqHtzwKOX1KPA7tmaQqrt2HQ+3osIsz6s pW2ZZVFriWfmiVMSXqIPyy9VGc5kEZL1witMaGarpxJBkmkkxVi7pdF5U9mXMGSg 02OTz+Qr63npgvV0vHsFQQReqZhbZ770CVBi5ItA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=ML3LV4 VHsCLLba750jBGQAAHjHKbtL74tr0YZbJOhtE=; b=MhZyi09G7lVvGKtbDpaph3 97ni7zOvgpH6x/MHD0b8jrAROd2vNmg7NTDyrtoRlaXPstydahCp+bMhAFwy4DuI DditUqjUxcL6zZwWAEVlffJPkU3UpuIlI1FzwtWQUSHd+Abwln7/3DMuCpaUizJ+ cb7sgcM8aHmnFBnHn2re7g3zgqbLWaTAmYV6Li14i9t8Et7oOMyaRsj996TOZ8yX 0E7f4z+kPD9OlOn7PQyGxEbOdZIfxyC3pnJ+02pZ3q9bPWrdbUoqYBd+njCbyJTD 8l9CNdVyg8YmdzImIk4Z8hHMFtc+Qwb+aMa31SIxne/JLJHwB+8CuqrW3yssMgXg == X-ME-Sender: X-Sasl-enc: 0TJ1UDPkqPNdJ1fwGZsfQ0MeYJJgVA6Q4RkBR8Maq6u1 1495916410 X-Mailer: git-send-email 2.13.0 Xref: news.gmane.org gmane.linux.lib.musl.general:11356 Archived-At: The flags argument was missing, causing uninitalized data to be passed to fchownat(2). The correct value of flags should match the fallback for chown(3). --- src/unistd/fchown.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/unistd/fchown.c b/src/unistd/fchown.c index 03459849..75075eec 100644 --- a/src/unistd/fchown.c +++ b/src/unistd/fchown.c @@ -16,7 +16,7 @@ int fchown(int fd, uid_t uid, gid_t gid) #ifdef SYS_chown return syscall(SYS_chown, buf, uid, gid); #else - return syscall(SYS_fchownat, AT_FDCWD, buf, uid, gid); + return syscall(SYS_fchownat, AT_FDCWD, buf, uid, gid, 0); #endif } -- 2.13.0