mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix fchown fallback on arches without chown(2)
Date: Sat, 27 May 2017 22:04:21 -0400	[thread overview]
Message-ID: <20170528020421.GE1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <20170527202001.27170-1-samuel@sholland.org>

On Sat, May 27, 2017 at 03:20:01PM -0500, Samuel Holland wrote:
> The flags argument was missing, causing uninitalized data to be passed
> to fchownat(2). The correct value of flags should match the fallback for
> chown(3).
> ---
>  src/unistd/fchown.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/unistd/fchown.c b/src/unistd/fchown.c
> index 03459849..75075eec 100644
> --- a/src/unistd/fchown.c
> +++ b/src/unistd/fchown.c
> @@ -16,7 +16,7 @@ int fchown(int fd, uid_t uid, gid_t gid)
>  #ifdef SYS_chown
>  	return syscall(SYS_chown, buf, uid, gid);
>  #else
> -	return syscall(SYS_fchownat, AT_FDCWD, buf, uid, gid);
> +	return syscall(SYS_fchownat, AT_FDCWD, buf, uid, gid, 0);
>  #endif
>  
>  }
> -- 
> 2.13.0

Thanks. Applying.

Rich


      reply	other threads:[~2017-05-28  2:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-27 20:20 Samuel Holland
2017-05-28  2:04 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170528020421.GE1627@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).