From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: [PATCH] s390x: Add single instruction math functions
Date: Mon, 12 Jun 2017 22:28:52 +0200 [thread overview]
Message-ID: <20170612202851.GA27071@port70.net> (raw)
In-Reply-To: <CAGWvny=pxWAy=FfaxNG=N-ZxEggq8iy9GFPRTJuE-A8=QZAOwQ@mail.gmail.com>
* David Edelsohn <dje.gcc@gmail.com> [2017-06-12 09:54:54 -0400]:
> On Mon, Jun 12, 2017 at 9:28 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
> > On Mon, Jun 12, 2017 at 5:03 AM, Szabolcs Nagy <nsz@port70.net> wrote:
> >> * David Edelsohn <dje.gcc@gmail.com> [2017-06-11 22:46:09 -0400]:
> >>> The following IBM table of supported and tested systems
> >>>
> >>> https://www-03.ibm.com/systems/z/os/linux/resources/testedplatforms.html
> >>>
> >>> shows that RHEL 7 and SLES 12 require at least z196, and Ubuntu 16.04
> >>> requires at least zEC12.
> >>>
> >>> I can't find any official hardware requirements description for Alpine
> >>> Linux. I tend to doubt that user would run it on older hardware,
> >>> especially hardware no longer supported by other, modern Linux
> >>> distributions.
> >>>
> >>> Building musl libc on older hardware is a nice accomplishment, but
> >>> investing effort and complexity to maintain support probably isn't
> >>> useful to any musl libc user and probably isn't a productive use of
> >>> developer resources.
> >>>
> >>> I will continue to inquire if there is a simple technique to accomplish this.
> >
> > Apparently GCC 7.1 added architecture macros.
> >
> > As Tuan referenced, Alpine Linux also requires z196 as the minimum
> > architecture level. I believe that it would be better for s390-musl
> > to default to z196 ISA than musl to require GCC 7.1.
>
> Would a patch such as the following be acceptable?
>
> Thanks, David
>
> diff --git a/configure b/configure
> index c2db298..a9e0256 100755
> --- a/configure
> +++ b/configure
> @@ -494,6 +494,15 @@ fnmatch '-mtune=*|*\ -mtune=*' "$CC $CFLAGS" || tryldflag C
> fi
>
> #
> +# On s390x, default to z196 architecture and zEC12 tuning to support newer math
> +# instructions.
> +#
> +if test "$ARCH" = "s390x" ; then
> +fnmatch '-march=*|*\ -march=*' "$CC $CFLAGS" || tryldflag CFLAGS_AUTO
> -march=z196
> +fnmatch '-mtune=*|*\ -mtune=*' "$CC $CFLAGS" || tryldflag CFLAGS_AUTO
> -mtune=zEC12
> +fi
> +
> +#
> # Even with -std=c99, gcc accepts some constructs which are constraint
> # violations. We want to treat these as errors regardless of whether
> # other purely stylistic warnings are enabled -- especially implicit
well the toolchain may be configured for a different/newer cpu
and then we may not want to override that.. what about
diff --git a/configure b/configure
index c2db298c..bcaf3a7d 100755
--- a/configure
+++ b/configure
@@ -656,6 +656,12 @@ trycppif __LITTLE_ENDIAN__ "$t" && SUBARCH=${SUBARCH}le
trycppif _SOFT_FLOAT "$t" && fail "$0: error: soft-float not supported on powerpc64"
fi
+if test "$ARCH" = "s390x" ; then
+echo 'float x; void f(){__asm__("fiebra %0,6,%1,4":"=f"(x):"f"(x));}' > "$tmpc"
+$CC $CFLAGS_C99FSE $CPPFLAGS $CFLAGS -c -o /dev/null "$tmpc" >/dev/null 2>&1 ||
+ fail "$0: error: s390x isa level is too low, use at least -march=z196"
+fi
+
if test "$ARCH" = "sh" ; then
tryflag CFLAGS_AUTO -Wa,--isa=any
trycppif __BIG_ENDIAN__ "$t" && SUBARCH=${SUBARCH}eb
next prev parent reply other threads:[~2017-06-12 20:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 14:51 David Edelsohn
2017-06-10 15:36 ` Szabolcs Nagy
2017-06-10 17:25 ` David Edelsohn
2017-06-10 18:29 ` Szabolcs Nagy
2017-06-10 18:53 ` David Edelsohn
2017-06-10 19:48 ` Rich Felker
2017-06-10 20:22 ` David Edelsohn
2017-06-10 21:28 ` Szabolcs Nagy
2017-06-10 21:44 ` David Edelsohn
2017-06-10 21:48 ` David Edelsohn
2017-06-11 2:20 ` Rich Felker
2017-06-11 10:19 ` Szabolcs Nagy
2017-06-11 15:04 ` Rich Felker
2017-06-11 16:45 ` Szabolcs Nagy
2017-06-11 21:45 ` Rich Felker
2017-06-12 2:46 ` David Edelsohn
2017-06-12 4:36 ` Tuan M. Hoang
2017-06-12 9:03 ` Szabolcs Nagy
2017-06-12 13:28 ` David Edelsohn
2017-06-12 13:54 ` David Edelsohn
2017-06-12 20:28 ` Szabolcs Nagy [this message]
2017-06-12 21:02 ` David Edelsohn
2017-06-13 15:55 ` Szabolcs Nagy
2017-06-14 23:34 ` Rich Felker
2017-06-14 23:40 ` A. Wilcox
2017-06-14 23:44 ` Rich Felker
2017-06-15 12:18 ` David Edelsohn
2017-06-18 17:12 ` David Edelsohn
2017-06-21 0:49 ` Rich Felker
2017-06-21 1:07 ` David Edelsohn
2017-06-21 1:20 ` Rich Felker
2017-06-21 3:34 ` David Edelsohn
2017-06-23 19:31 ` Rich Felker
2017-06-10 21:37 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612202851.GA27071@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).