From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Ignored patch
Date: Fri, 23 Jun 2017 15:37:38 -0400 [thread overview]
Message-ID: <20170623193738.GP1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <2569601498217261@web29o.yandex.ru>
On Fri, Jun 23, 2017 at 02:27:41PM +0300, Dmitry Golovin wrote:
> I have already posted this patch on this mailing list (the original
> subject was "Proper warning silencing patch for Clang"), but I
> didn't get any feedback about it. Maybe it is not formatted properly
> or there is some other problem with it. Please let me know if
> something is wrong with this patch.
>
> Regards,
> Dmitry
> From c37efc541b12d8e216b7a425808e4c24c48f9213 Mon Sep 17 00:00:00 2001
> From: Dmitry Golovin <dima@golovin.in>
> Date: Fri, 9 Jun 2017 16:41:53 +0300
> Subject: [PATCH] add proper check for clang supported optimization and stop
> complaining about unused arguements
>
> ---
> configure | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/configure b/configure
> index c2db298..539c9fc 100755
> --- a/configure
> +++ b/configure
> @@ -249,6 +249,7 @@ fi
> #
> tryflag CFLAGS_TRY -Werror=unknown-warning-option
> tryflag CFLAGS_TRY -Werror=unused-command-line-argument
> +tryflag CFLAGS_TRY -Werror=ignored-optimization-argument
> tryldflag LDFLAGS_TRY -Werror=unknown-warning-option
> tryldflag LDFLAGS_TRY -Werror=unused-command-line-argument
>
> @@ -504,6 +505,13 @@ tryflag CFLAGS_AUTO -Werror=implicit-int
> tryflag CFLAGS_AUTO -Werror=pointer-sign
> tryflag CFLAGS_AUTO -Werror=pointer-arith
>
> +#
> +# GCC ignores unused arguements by default, but Clang needs this extra
> +# parameter to stop printing warnings about LDFLAGS passed during
> +# compiling stage and CFLAGS passed during linking stage.
> +#
> +tryflag CFLAGS_AUTO -Qunused-arguments
> +
> if test "x$warnings" = xyes ; then
> tryflag CFLAGS_AUTO -Wall
> tryflag CFLAGS_AUTO -Wno-parentheses
> --
> 2.13.0
>
I think this looks good; I've just been trying to get through patch
backlog while new ones keep coming in. I'll try it and make sure it
seems to behave okay on a system with clang soon and commit it if
nothing goes wrong.
Rich
prev parent reply other threads:[~2017-06-23 19:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 11:27 Dmitry Golovin
2017-06-23 19:37 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623193738.GP1627@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).