From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11576 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Ignored patch Date: Fri, 23 Jun 2017 15:37:38 -0400 Message-ID: <20170623193738.GP1627@brightrain.aerifal.cx> References: <2569601498217261@web29o.yandex.ru> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1498246678 17079 195.159.176.226 (23 Jun 2017 19:37:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Jun 2017 19:37:58 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-11589-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 23 21:37:53 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1dOUOp-0003ty-8V for gllmg-musl@m.gmane.org; Fri, 23 Jun 2017 21:37:47 +0200 Original-Received: (qmail 1761 invoked by uid 550); 23 Jun 2017 19:37:50 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 1736 invoked from network); 23 Jun 2017 19:37:50 -0000 Content-Disposition: inline In-Reply-To: <2569601498217261@web29o.yandex.ru> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:11576 Archived-At: On Fri, Jun 23, 2017 at 02:27:41PM +0300, Dmitry Golovin wrote: > I have already posted this patch on this mailing list (the original > subject was "Proper warning silencing patch for Clang"), but I > didn't get any feedback about it. Maybe it is not formatted properly > or there is some other problem with it. Please let me know if > something is wrong with this patch. > > Regards, > Dmitry > From c37efc541b12d8e216b7a425808e4c24c48f9213 Mon Sep 17 00:00:00 2001 > From: Dmitry Golovin > Date: Fri, 9 Jun 2017 16:41:53 +0300 > Subject: [PATCH] add proper check for clang supported optimization and stop > complaining about unused arguements > > --- > configure | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/configure b/configure > index c2db298..539c9fc 100755 > --- a/configure > +++ b/configure > @@ -249,6 +249,7 @@ fi > # > tryflag CFLAGS_TRY -Werror=unknown-warning-option > tryflag CFLAGS_TRY -Werror=unused-command-line-argument > +tryflag CFLAGS_TRY -Werror=ignored-optimization-argument > tryldflag LDFLAGS_TRY -Werror=unknown-warning-option > tryldflag LDFLAGS_TRY -Werror=unused-command-line-argument > > @@ -504,6 +505,13 @@ tryflag CFLAGS_AUTO -Werror=implicit-int > tryflag CFLAGS_AUTO -Werror=pointer-sign > tryflag CFLAGS_AUTO -Werror=pointer-arith > > +# > +# GCC ignores unused arguements by default, but Clang needs this extra > +# parameter to stop printing warnings about LDFLAGS passed during > +# compiling stage and CFLAGS passed during linking stage. > +# > +tryflag CFLAGS_AUTO -Qunused-arguments > + > if test "x$warnings" = xyes ; then > tryflag CFLAGS_AUTO -Wall > tryflag CFLAGS_AUTO -Wno-parentheses > -- > 2.13.0 > I think this looks good; I've just been trying to get through patch backlog while new ones keep coming in. I'll try it and make sure it seems to behave okay on a system with clang soon and commit it if nothing goes wrong. Rich