From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: more on missing volatile qualifications
Date: Sun, 25 Jun 2017 12:17:04 +0200 [thread overview]
Message-ID: <20170625101704.GA2032@port70.net> (raw)
In-Reply-To: <20170625104516.17ac9466@inria.fr>
* Jens Gustedt <jens.gustedt@inria.fr> [2017-06-25 10:45:16 +0200]:
>
> - the definition of pthread_once_t
> - the definition of pthread_spinlock_t
> - the handler array in sigaction.c
>
> All three could benefit for an additional volatile qualification. All
> their usages are already so, so this would just be conservative and
> not risk any incompatibilities, I think.
pthread_once_t and pthread_spinlock_t qualifiers are
visible in the c++ name mangling if a c++ function takes
pointer to them as arguments so the change is an abi break.
> Also, I can't think of any semantics for the three, where opitimizing
> out loads or stores makes any sense, so this also should never see any
> kind of performance regression.
there was a case in glibc when volatile caused problems:
some generic atomic macro tried to create a temporary using
__typeof(*(p)) __tmp = *(p);
but then __tmp become volatile and operations on it generated
useless load/stores to the stack. it could be worked around as
__typeof( (__typeof(*(p))) *(p) ) __tmp = *(p);
is not volatile because the cast expression is unqualified.
(musl does not have such __typeof hacks, but it is an
example where volatile caused unexpeced regression)
next prev parent reply other threads:[~2017-06-25 10:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-25 8:45 Jens Gustedt
2017-06-25 10:17 ` Szabolcs Nagy [this message]
2017-06-25 11:06 ` Jens Gustedt
2017-07-04 21:19 ` Rich Felker
2017-07-04 22:03 ` Jens Gustedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170625101704.GA2032@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).