From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11618 Path: news.gmane.org!.POSTED!not-for-mail From: Alexander Monakov Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] fix undefined behavior in ptrace Date: Wed, 28 Jun 2017 16:25:13 +0300 Message-ID: <20170628132513.15483-1-amonakov@ispras.ru> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1498656329 11596 195.159.176.226 (28 Jun 2017 13:25:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Jun 2017 13:25:29 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-11631-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jun 28 15:25:25 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1dQCyC-0002oc-Sf for gllmg-musl@m.gmane.org; Wed, 28 Jun 2017 15:25:24 +0200 Original-Received: (qmail 13503 invoked by uid 550); 28 Jun 2017 13:25:26 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 13462 invoked from network); 28 Jun 2017 13:25:25 -0000 X-Mailer: git-send-email 2.11.0 Xref: news.gmane.org gmane.linux.lib.musl.general:11618 Archived-At: --- src/linux/ptrace.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/linux/ptrace.c b/src/linux/ptrace.c index 83b8022b..ab7fcda3 100644 --- a/src/linux/ptrace.c +++ b/src/linux/ptrace.c @@ -7,14 +7,17 @@ long ptrace(int req, ...) { va_list ap; pid_t pid; - void *addr, *data, *addr2; + void *addr, *data, *addr2 = 0; long ret, result; va_start(ap, req); pid = va_arg(ap, pid_t); addr = va_arg(ap, void *); data = va_arg(ap, void *); + /* PTRACE_{READ,WRITE}{DATA,TEXT} are specific to SPARC. */ +#ifdef PTRACE_READTEXT addr2 = va_arg(ap, void *); +#endif va_end(ap); if (req-1U < 3) data = &result; -- 2.11.0