From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix undefined behavior in ptrace
Date: Wed, 28 Jun 2017 11:13:28 -0400 [thread overview]
Message-ID: <20170628151328.GD1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <20170628132513.15483-1-amonakov@ispras.ru>
On Wed, Jun 28, 2017 at 04:25:13PM +0300, Alexander Monakov wrote:
> ---
> src/linux/ptrace.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/linux/ptrace.c b/src/linux/ptrace.c
> index 83b8022b..ab7fcda3 100644
> --- a/src/linux/ptrace.c
> +++ b/src/linux/ptrace.c
> @@ -7,14 +7,17 @@ long ptrace(int req, ...)
> {
> va_list ap;
> pid_t pid;
> - void *addr, *data, *addr2;
> + void *addr, *data, *addr2 = 0;
> long ret, result;
>
> va_start(ap, req);
> pid = va_arg(ap, pid_t);
> addr = va_arg(ap, void *);
> data = va_arg(ap, void *);
> + /* PTRACE_{READ,WRITE}{DATA,TEXT} are specific to SPARC. */
> +#ifdef PTRACE_READTEXT
> addr2 = va_arg(ap, void *);
> +#endif
I think there's still UB here, reading more args than were passed.
These calls to va_arg should probably be dependent on the particular
req; I don't see any reason for it to be compile-time dependent on the
presence of one particular req value.
Otherwise yes it's an improvement.
Rich
next prev parent reply other threads:[~2017-06-28 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 13:25 Alexander Monakov
2017-06-28 15:13 ` Rich Felker [this message]
2017-06-28 15:22 ` Alexander Monakov
2017-07-04 21:10 ` Rich Felker
2017-07-04 21:51 ` Alexander Monakov
2017-07-04 21:53 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628151328.GD1627@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).