From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix undefined behavior in ptrace
Date: Tue, 4 Jul 2017 17:10:58 -0400 [thread overview]
Message-ID: <20170704211058.GO1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <alpine.LNX.2.20.13.1706281821260.22548@monopod.intra.ispras.ru>
On Wed, Jun 28, 2017 at 06:22:12PM +0300, Alexander Monakov wrote:
> On Wed, 28 Jun 2017, Rich Felker wrote:
> > I think there's still UB here, reading more args than were passed.
> > These calls to va_arg should probably be dependent on the particular
> > req; I don't see any reason for it to be compile-time dependent on the
> > presence of one particular req value.
>
> I raised that last year but there was no response:
> http://www.openwall.com/lists/musl/2016/05/04/18
I'm sorry for overlooking it then. Could you submit a fleshed-out
patch that uses that approach? Assuming the arg types are always the
same, and only the number of args varies by command, a nicer approach
than nested if's with a bunch of equality comparisons each might be a
switch statement to map commands to # of args, then
if (nargs>=1) pid = va_arg(ap, pid_t);
if (nargs>=2) addr = va_arg(ap, void *);
...
Thoughts?
Rich
next prev parent reply other threads:[~2017-07-04 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 13:25 Alexander Monakov
2017-06-28 15:13 ` Rich Felker
2017-06-28 15:22 ` Alexander Monakov
2017-07-04 21:10 ` Rich Felker [this message]
2017-07-04 21:51 ` Alexander Monakov
2017-07-04 21:53 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704211058.GO1627@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).