From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix undefined behavior in free
Date: Tue, 4 Jul 2017 17:11:41 -0400 [thread overview]
Message-ID: <20170704211141.GP1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <20170627175847.13827-1-amonakov@ispras.ru>
On Tue, Jun 27, 2017 at 08:58:47PM +0300, Alexander Monakov wrote:
> ---
> src/malloc/malloc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/malloc/malloc.c b/src/malloc/malloc.c
> index 720fa696..ef4c7368 100644
> --- a/src/malloc/malloc.c
> +++ b/src/malloc/malloc.c
> @@ -463,14 +463,15 @@ copy_realloc:
>
> void free(void *p)
> {
> - struct chunk *self = MEM_TO_CHUNK(p);
> - struct chunk *next;
> + struct chunk *self, *next;
> size_t final_size, new_size, size;
> int reclaim=0;
> int i;
>
> if (!p) return;
>
> + self = MEM_TO_CHUNK(p);
> +
> if (IS_MMAPPED(self)) {
> size_t extra = self->psize;
> char *base = (char *)self - extra;
> --
> 2.11.0
Thanks, applied
Rich
prev parent reply other threads:[~2017-07-04 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 17:58 Alexander Monakov
2017-07-04 21:11 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704211141.GP1627@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).