* [PATCH] Change ENDIAN_SUFFIX definition from 'le' to 'el'
@ 2017-07-05 15:07 liu.ming50
2017-07-05 15:15 ` Rich Felker
0 siblings, 1 reply; 2+ messages in thread
From: liu.ming50 @ 2017-07-05 15:07 UTC (permalink / raw)
To: koorogi, musl; +Cc: Ming Liu
From: Ming Liu <peter.x.liu@external.atlascopco.com>
To be consistent with the same macros in other ARCHs.
Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
---
arch/powerpc64/reloc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc64/reloc.h b/arch/powerpc64/reloc.h
index faf70ac..9a4744a 100644
--- a/arch/powerpc64/reloc.h
+++ b/arch/powerpc64/reloc.h
@@ -1,7 +1,7 @@
#include <endian.h>
#if __BYTE_ORDER == __LITTLE_ENDIAN
-#define ENDIAN_SUFFIX "le"
+#define ENDIAN_SUFFIX "el"
#else
#define ENDIAN_SUFFIX ""
#endif
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Change ENDIAN_SUFFIX definition from 'le' to 'el'
2017-07-05 15:07 [PATCH] Change ENDIAN_SUFFIX definition from 'le' to 'el' liu.ming50
@ 2017-07-05 15:15 ` Rich Felker
0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2017-07-05 15:15 UTC (permalink / raw)
To: musl
On Wed, Jul 05, 2017 at 05:07:17PM +0200, liu.ming50@gmail.com wrote:
> From: Ming Liu <peter.x.liu@external.atlascopco.com>
>
> To be consistent with the same macros in other ARCHs.
>
> Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
> ---
> arch/powerpc64/reloc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc64/reloc.h b/arch/powerpc64/reloc.h
> index faf70ac..9a4744a 100644
> --- a/arch/powerpc64/reloc.h
> +++ b/arch/powerpc64/reloc.h
> @@ -1,7 +1,7 @@
> #include <endian.h>
>
> #if __BYTE_ORDER == __LITTLE_ENDIAN
> -#define ENDIAN_SUFFIX "le"
> +#define ENDIAN_SUFFIX "el"
> #else
> #define ENDIAN_SUFFIX ""
> #endif
> --
> 2.7.4
This is an ABI-breaking change and thus not appropriate. Anyway, the
intent is not to be consistent with other archs but too be consistent
with existing naming practice for the particular arch, where
powerpc64le, not powerpc64el, is what's used.
BTW if it were being changed, the subarch logic in configure would
also need to be changed to match.
Rich
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-05 15:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-05 15:07 [PATCH] Change ENDIAN_SUFFIX definition from 'le' to 'el' liu.ming50
2017-07-05 15:15 ` Rich Felker
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).