From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11757 Path: news.gmane.org!.POSTED!not-for-mail From: Thomas Petazzoni Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] arch/sh/atomic_arch.sh: add missing : in asm() statement Date: Fri, 28 Jul 2017 23:05:54 +0200 Message-ID: <20170728210554.6391-1-thomas.petazzoni@free-electrons.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1501275981 1954 195.159.176.226 (28 Jul 2017 21:06:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 28 Jul 2017 21:06:21 +0000 (UTC) Cc: Thomas Petazzoni To: musl@lists.openwall.com Original-X-From: musl-return-11770-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jul 28 23:06:16 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1dbCSW-0008K6-Sw for gllmg-musl@m.gmane.org; Fri, 28 Jul 2017 23:06:08 +0200 Original-Received: (qmail 30121 invoked by uid 550); 28 Jul 2017 21:06:11 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 30092 invoked from network); 28 Jul 2017 21:06:09 -0000 X-Mailer: git-send-email 2.9.4 Xref: news.gmane.org gmane.linux.lib.musl.general:11757 Archived-At: Due to a missing ":" in an asm() statement, the "memory" statement is considered by gcc as input operands and not clobbers, which causes a build failure: In file included from ./src/internal/atomic.h:6:0, from ./src/internal/pthread_impl.h:10, from src/ldso/dlerror.c:4: ./arch/sh/atomic_arch.h: In function 'a_barrier': ./arch/sh/atomic_arch.h:24:44: error: expected '(' before ')' token __asm__ __volatile__ ("synco" : : "memory"); ^ Signed-off-by: Thomas Petazzoni --- arch/sh/atomic_arch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sh/atomic_arch.h b/arch/sh/atomic_arch.h index 74444d5..d48a765 100644 --- a/arch/sh/atomic_arch.h +++ b/arch/sh/atomic_arch.h @@ -21,7 +21,7 @@ static inline int a_sc(volatile int *p, int v) #define a_barrier a_barrier static inline void a_barrier() { - __asm__ __volatile__ ("synco" : : "memory"); + __asm__ __volatile__ ("synco" ::: "memory"); } #define a_pre_llsc a_barrier -- 2.9.4