From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11802 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] arch/sh/atomic_arch.sh: add missing : in asm() statement Date: Fri, 11 Aug 2017 20:55:05 -0400 Message-ID: <20170812005505.GQ1627@brightrain.aerifal.cx> References: <20170728210554.6391-1-thomas.petazzoni@free-electrons.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1502499327 12745 195.159.176.226 (12 Aug 2017 00:55:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 Aug 2017 00:55:27 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-11815-gllmg-musl=m.gmane.org@lists.openwall.com Sat Aug 12 02:55:20 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1dgKht-0002WK-TT for gllmg-musl@m.gmane.org; Sat, 12 Aug 2017 02:55:14 +0200 Original-Received: (qmail 8022 invoked by uid 550); 12 Aug 2017 00:55:19 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 7995 invoked from network); 12 Aug 2017 00:55:18 -0000 Content-Disposition: inline In-Reply-To: <20170728210554.6391-1-thomas.petazzoni@free-electrons.com> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:11802 Archived-At: On Fri, Jul 28, 2017 at 11:05:54PM +0200, Thomas Petazzoni wrote: > Due to a missing ":" in an asm() statement, the "memory" statement is > considered by gcc as input operands and not clobbers, which causes a > build failure: > > In file included from ./src/internal/atomic.h:6:0, > from ./src/internal/pthread_impl.h:10, > from src/ldso/dlerror.c:4: > ../arch/sh/atomic_arch.h: In function 'a_barrier': > ../arch/sh/atomic_arch.h:24:44: error: expected '(' before ')' token > __asm__ __volatile__ ("synco" : : "memory"); > ^ > > Signed-off-by: Thomas Petazzoni > --- > arch/sh/atomic_arch.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/atomic_arch.h b/arch/sh/atomic_arch.h > index 74444d5..d48a765 100644 > --- a/arch/sh/atomic_arch.h > +++ b/arch/sh/atomic_arch.h > @@ -21,7 +21,7 @@ static inline int a_sc(volatile int *p, int v) > #define a_barrier a_barrier > static inline void a_barrier() > { > - __asm__ __volatile__ ("synco" : : "memory"); > + __asm__ __volatile__ ("synco" ::: "memory"); > } > > #define a_pre_llsc a_barrier > -- > 2.9.4 Thanks! Applying. Rich