mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: SIOCGSTAMPNS definition missing
Date: Sun, 13 Aug 2017 18:35:15 +0200	[thread overview]
Message-ID: <20170813163515.GH15263@port70.net> (raw)
In-Reply-To: <20170813160301.GG15263@port70.net>

* Szabolcs Nagy <nsz@port70.net> [2017-08-13 18:03:01 +0200]:

> * Rich Felker <dalias@libc.org> [2017-08-11 20:53:38 -0400]:
> > On Tue, Aug 01, 2017 at 10:08:02AM +0000, yamabiko@onenetbeyond.org wrote:
> > > Hello,
> > > when I tried to compile qemu on a Gentoo musl based system it
> > > complained about "SIOCGSTAMPNS" being undeclared. Using
> > > "-DSIOCGSTAMPNS=0x8907" as CFLAG worked as a workaround. So it looks
> > > like the definition it's missing from some header file (ioctl.h?)
> > > See https://forums.gentoo.org/viewtopic-t-1066924.html for more info
> > 
> > Thanks for the report.
> > 
> > Has anyone else looked at this yet? It probably needs per-arch
> > additions to the bits/ioctl.h headers.
> > 
> 
> it seems to be defined in asm/sockios.h which
> is included via sys/socket.h in glibc i think so
> musl should put it into sys/socket.h if anywhere.

it seems i proposed the sockios stuff to be removed
from ioctl.h, but that was not applied:

http://www.openwall.com/lists/musl/2016/07/03/22

i think those sockios macros should be moved from
ioctl.h to socket.h and the SIOCGSTAMPNS should
be added to them. (or we can add the macro now
to ioctl.h and move them later)

one issue is that the mips macros are currently
wrong (don't match the kernel uapi definitions).


  reply	other threads:[~2017-08-13 16:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 10:08 yamabiko
2017-08-12  0:53 ` Rich Felker
2017-08-13 16:03   ` Szabolcs Nagy
2017-08-13 16:35     ` Szabolcs Nagy [this message]
2017-08-13 17:23       ` Rich Felker
2017-08-13 20:46         ` [PATCH 1/2] fix mips ioctl macros to match linux asm/sockios.h Szabolcs Nagy
2017-08-13 20:47         ` [PATCH 2/2] add SIOCGSTAMPNS socket ioctl macro to ioctl.h Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170813163515.GH15263@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).