From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: fnmatch bug? escaping of '-' and ']' inside [...] does not work.
Date: Tue, 15 Aug 2017 10:28:16 -0400 [thread overview]
Message-ID: <20170815142816.GU1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAK1hOcPAE-usFVzRrNMV0QPZPErX8Dww0hA3GjkoC1xAKxXjHA@mail.gmail.com>
On Tue, Aug 15, 2017 at 03:12:17PM +0200, Denys Vlasenko wrote:
> Moving bbox build to musl did uncover one definite bug.
> bbox has gazillion tests for its shells, and one of them
> started failing. I added debug printout and with it,
> the following fnmatch calls give different results now:
>
> ash: fnmatch(pattern:'[a\-c]',str:'-',0):1
> ash: fnmatch(pattern:'[\]]',str:']',0):1
> ash: fnmatch(pattern:'[a\]]',str:']',0):1
>
> glibc and uclibc threat the above as a match.
I believe this is connected to a known discrepancy between what the
standard seems to say and what glibc is doing. I'll see if I can dig
up past discussions of it. If it's coming up again, it's likely that
this is an issue that needs a proper interpretation (and possibly fix
in the language of the standard, if the current text really does imply
something different than what it's supposed to; the fix might end up
being along the lines of "it's unspecified whether...").
Rich
prev parent reply other threads:[~2017-08-15 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 13:12 Denys Vlasenko
2017-08-15 14:25 ` Szabolcs Nagy
2017-08-15 14:28 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815142816.GU1627@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).