From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] syslog.h: fix warning "initialization discards 'const' qualifier from pointer target type"
Date: Wed, 16 Aug 2017 09:24:25 -0400 [thread overview]
Message-ID: <20170816132425.GV1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <20170816091837.10436-1-vda.linux@googlemail.com>
On Wed, Aug 16, 2017 at 11:18:37AM +0200, Denys Vlasenko wrote:
> This happens when syslog.h is included with "#define SYSLOG_NAMES 1"
>
> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
> CC: musl@lists.openwall.com
> ---
> include/syslog.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/syslog.h b/include/syslog.h
> index 5b4d296..25eb3e4 100644
> --- a/include/syslog.h
> +++ b/include/syslog.h
> @@ -70,7 +70,7 @@ void vsyslog (int, const char *, va_list);
> #define INTERNAL_NOPRI 0x10
> #define INTERNAL_MARK (LOG_NFACILITIES<<3)
> typedef struct {
> - char *c_name;
> + const char *c_name;
> int c_val;
> } CODE;
> #define prioritynames ((CODE *)(const CODE []){ \
> --
> 2.9.2
This is not the right fix; it changes the type of a struct member
that's a public interface and thereby invalidates correct code that
was using it.
The cause is a bug (#61579) in GCC whereby -Wwrite-strings changes the
language semantics (changes the type of string literals) rather than
just generating a warning. Removing this option will fix it.
However there are other reasons that having the names done with a
compound literal rather than an external symbol is a bad idea (and
contributing significant size waste to busybox, IIRC), and I suspect
the right fix will make your problem go away too.
Rich
prev parent reply other threads:[~2017-08-16 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 9:18 Denys Vlasenko
2017-08-16 13:24 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816132425.GV1627@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).