From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11930 Path: news.gmane.org!.POSTED!not-for-mail From: "A. Wilcox" Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] __lookup_serv: return correct error code Date: Thu, 14 Sep 2017 15:53:21 -0500 Message-ID: <20170914205321.18733-1-awilfox@adelielinux.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505422444 18809 195.159.176.226 (14 Sep 2017 20:54:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 14 Sep 2017 20:54:04 +0000 (UTC) Cc: "A. Wilcox" To: musl@lists.openwall.com Original-X-From: musl-return-11943-gllmg-musl=m.gmane.org@lists.openwall.com Thu Sep 14 22:53:59 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1dsb92-0004gM-KS for gllmg-musl@m.gmane.org; Thu, 14 Sep 2017 22:53:56 +0200 Original-Received: (qmail 30109 invoked by uid 550); 14 Sep 2017 20:54:02 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 30072 invoked from network); 14 Sep 2017 20:54:01 -0000 X-Mailer: git-send-email 2.10.0 Xref: news.gmane.org gmane.linux.lib.musl.general:11930 Archived-At: From: "A. Wilcox" If AI_NUMERICSERV is specified and a numeric service was not provided, POSIX mandates getaddrinfo return EAI_NONAME. EAI_SERVICE is only for services that cannot be used on the specified socket type. --- src/network/lookup_serv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/lookup_serv.c b/src/network/lookup_serv.c index 66ebaea..403b12a 100644 --- a/src/network/lookup_serv.c +++ b/src/network/lookup_serv.c @@ -64,7 +64,7 @@ int __lookup_serv(struct service buf[static MAXSERVS], const char *name, int pro return cnt; } - if (flags & AI_NUMERICSERV) return EAI_SERVICE; + if (flags & AI_NUMERICSERV) return EAI_NONAME; size_t l = strlen(name); -- 2.10.0