* [PATCH] __lookup_serv: return correct error code
@ 2017-09-14 20:53 A. Wilcox
2017-09-14 21:48 ` Rich Felker
0 siblings, 1 reply; 3+ messages in thread
From: A. Wilcox @ 2017-09-14 20:53 UTC (permalink / raw)
To: musl; +Cc: A. Wilcox
From: "A. Wilcox" <AWilcox@Wilcox-Tech.com>
If AI_NUMERICSERV is specified and a numeric service was not provided,
POSIX mandates getaddrinfo return EAI_NONAME. EAI_SERVICE is only for
services that cannot be used on the specified socket type.
---
src/network/lookup_serv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/network/lookup_serv.c b/src/network/lookup_serv.c
index 66ebaea..403b12a 100644
--- a/src/network/lookup_serv.c
+++ b/src/network/lookup_serv.c
@@ -64,7 +64,7 @@ int __lookup_serv(struct service buf[static MAXSERVS], const char *name, int pro
return cnt;
}
- if (flags & AI_NUMERICSERV) return EAI_SERVICE;
+ if (flags & AI_NUMERICSERV) return EAI_NONAME;
size_t l = strlen(name);
--
2.10.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] __lookup_serv: return correct error code
2017-09-14 20:53 [PATCH] __lookup_serv: return correct error code A. Wilcox
@ 2017-09-14 21:48 ` Rich Felker
2017-11-06 0:44 ` Rich Felker
0 siblings, 1 reply; 3+ messages in thread
From: Rich Felker @ 2017-09-14 21:48 UTC (permalink / raw)
To: musl
On Thu, Sep 14, 2017 at 03:53:21PM -0500, A. Wilcox wrote:
> From: "A. Wilcox" <AWilcox@Wilcox-Tech.com>
>
> If AI_NUMERICSERV is specified and a numeric service was not provided,
> POSIX mandates getaddrinfo return EAI_NONAME. EAI_SERVICE is only for
> services that cannot be used on the specified socket type.
> ---
> src/network/lookup_serv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/network/lookup_serv.c b/src/network/lookup_serv.c
> index 66ebaea..403b12a 100644
> --- a/src/network/lookup_serv.c
> +++ b/src/network/lookup_serv.c
> @@ -64,7 +64,7 @@ int __lookup_serv(struct service buf[static MAXSERVS], const char *name, int pro
> return cnt;
> }
>
> - if (flags & AI_NUMERICSERV) return EAI_SERVICE;
> + if (flags & AI_NUMERICSERV) return EAI_NONAME;
>
> size_t l = strlen(name);
>
> --
> 2.10.0
I think you've uncovered a larger bug than the patch fixes; it looks
like most of the EAI_SERVICE return points in __lookup_serv are wrong.
Most should probably be EAI_NONAME; a couple should possibly be
EAI_SOCKTYPE. Thoughts?
Rich
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] __lookup_serv: return correct error code
2017-09-14 21:48 ` Rich Felker
@ 2017-11-06 0:44 ` Rich Felker
0 siblings, 0 replies; 3+ messages in thread
From: Rich Felker @ 2017-11-06 0:44 UTC (permalink / raw)
To: musl
On Thu, Sep 14, 2017 at 05:48:17PM -0400, Rich Felker wrote:
> On Thu, Sep 14, 2017 at 03:53:21PM -0500, A. Wilcox wrote:
> > From: "A. Wilcox" <AWilcox@Wilcox-Tech.com>
> >
> > If AI_NUMERICSERV is specified and a numeric service was not provided,
> > POSIX mandates getaddrinfo return EAI_NONAME. EAI_SERVICE is only for
> > services that cannot be used on the specified socket type.
> > ---
> > src/network/lookup_serv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/network/lookup_serv.c b/src/network/lookup_serv.c
> > index 66ebaea..403b12a 100644
> > --- a/src/network/lookup_serv.c
> > +++ b/src/network/lookup_serv.c
> > @@ -64,7 +64,7 @@ int __lookup_serv(struct service buf[static MAXSERVS], const char *name, int pro
> > return cnt;
> > }
> >
> > - if (flags & AI_NUMERICSERV) return EAI_SERVICE;
> > + if (flags & AI_NUMERICSERV) return EAI_NONAME;
> >
> > size_t l = strlen(name);
> >
> > --
> > 2.10.0
>
> I think you've uncovered a larger bug than the patch fixes; it looks
> like most of the EAI_SERVICE return points in __lookup_serv are wrong.
> Most should probably be EAI_NONAME; a couple should possibly be
> EAI_SOCKTYPE. Thoughts?
On further consideration, "AI_NUMERICSERV was specified and the
argument is not a numeric string" seems like the only case that
explicitly mandates EAI_NONAME. Specification of EAI_SERVICE is really
ambiguous/underspecified though. The patch is probably okay as-is.
Rich
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-06 0:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-14 20:53 [PATCH] __lookup_serv: return correct error code A. Wilcox
2017-09-14 21:48 ` Rich Felker
2017-11-06 0:44 ` Rich Felker
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).