mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix missing forward declaration of memset in sched.h
Date: Thu, 28 Sep 2017 12:56:24 -0400	[thread overview]
Message-ID: <20170928165624.GB1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <1506602691.16791.1.camel@embedded.rocks>

On Thu, Sep 28, 2017 at 02:44:51PM +0200, Jörg Krause wrote:
> Hi,
> 
> On Fri, 2017-09-08 at 11:39 +0200, Jörg Krause wrote:
> > Fixes build issue when using the macro `CPU_EQUAL()`, e.g. in Boost [1]:
> > 
> > ```
> > libs/fiber/src/numa/linux/pin_thread.cpp:31:5: error: 'memset' was not declared in this scope
> >      CPU_ZERO( & set);
> >      ^
> > ```
> > 
> > [1] https://github.com/boostorg/fiber/pull/142
> > 
> > Reported-by: Oliver Kowalke <oliver.kowalke@gmail.com>
> > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> > ---
> >  include/sched.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/sched.h b/include/sched.h
> > index d1cccb70..05d40b1e 100644
> > --- a/include/sched.h
> > +++ b/include/sched.h
> > @@ -72,6 +72,7 @@ int setns(int, int);
> >  
> >  void *memcpy(void *__restrict, const void *__restrict, size_t);
> >  int memcmp(const void *, const void *, size_t);
> > +void *memset (void *, int, size_t);
> >  void *calloc(size_t, size_t);
> >  void free(void *);
> >  
> 
> Any feedback on this?

It looks fine. Thanks and sorry for not replying sooner.

Rich


  reply	other threads:[~2017-09-28 16:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-08  9:39 Jörg Krause
2017-09-28 12:44 ` Jörg Krause
2017-09-28 16:56   ` Rich Felker [this message]
2017-10-02 16:41     ` Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170928165624.GB1627@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).