From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: Build failure on ARM <5
Date: Fri, 20 Oct 2017 21:36:45 +0200 [thread overview]
Message-ID: <20171020193645.GT15263@port70.net> (raw)
In-Reply-To: <20171020190400.2vbeywawzh2ompoa@apollo>
* Reiner Herrmann <reiner@reiner-h.de> [2017-10-20 21:04:00 +0200]:
> Hi,
>
> musl 1.1.17 fails to build [1] on arm versions <5 because
> of an unsupported clz instruction.
> The attached patch by Adrian Bunk [2] fixes this issue.
>
this is my bug sorry,
> diff --git a/arch/arm/atomic_arch.h b/arch/arm/atomic_arch.h
> index a121010f..c5c56f81 100644
> --- a/arch/arm/atomic_arch.h
> +++ b/arch/arm/atomic_arch.h
> @@ -82,9 +82,13 @@ static inline void a_crash()
> : : : "memory");
> }
>
> +#if __ARM_ARCH >= 5
> +
this is not enough: v5t and v6 only supports clz in arm mode
v6t2 and v7 supports it in thumb mode too.
i think we should either check for >= 7 conservatively or check
__ARM_FEATURE_CLZ which is defined in
https://developer.arm.com/docs/ihi0053/b/arm-c-language-extensions-release-11
> #define a_clz_32 a_clz_32
> static inline int a_clz_32(uint32_t x)
> {
> __asm__ ("clz %0, %1" : "=r"(x) : "r"(x));
> return x;
> }
> +
> +#endif
> --
> 2.15.0.rc1
>
next prev parent reply other threads:[~2017-10-20 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 19:04 Reiner Herrmann
2017-10-20 19:36 ` Szabolcs Nagy [this message]
2017-10-20 21:26 ` Rich Felker
2017-10-25 16:56 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020193645.GT15263@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).