From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12023 Path: news.gmane.org!.POSTED!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: Build failure on ARM <5 Date: Fri, 20 Oct 2017 21:36:45 +0200 Message-ID: <20171020193645.GT15263@port70.net> References: <20171020190400.2vbeywawzh2ompoa@apollo> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1508528235 14140 195.159.176.226 (20 Oct 2017 19:37:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Oct 2017 19:37:15 +0000 (UTC) User-Agent: Mutt/1.6.0 (2016-04-01) To: musl@lists.openwall.com Original-X-From: musl-return-12036-gllmg-musl=m.gmane.org@lists.openwall.com Fri Oct 20 21:37:09 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1e5d6C-0000zs-Ut for gllmg-musl@m.gmane.org; Fri, 20 Oct 2017 21:36:53 +0200 Original-Received: (qmail 3889 invoked by uid 550); 20 Oct 2017 19:36:57 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 3871 invoked from network); 20 Oct 2017 19:36:57 -0000 Mail-Followup-To: musl@lists.openwall.com Content-Disposition: inline In-Reply-To: <20171020190400.2vbeywawzh2ompoa@apollo> Xref: news.gmane.org gmane.linux.lib.musl.general:12023 Archived-At: * Reiner Herrmann [2017-10-20 21:04:00 +0200]: > Hi, > > musl 1.1.17 fails to build [1] on arm versions <5 because > of an unsupported clz instruction. > The attached patch by Adrian Bunk [2] fixes this issue. > this is my bug sorry, > diff --git a/arch/arm/atomic_arch.h b/arch/arm/atomic_arch.h > index a121010f..c5c56f81 100644 > --- a/arch/arm/atomic_arch.h > +++ b/arch/arm/atomic_arch.h > @@ -82,9 +82,13 @@ static inline void a_crash() > : : : "memory"); > } > > +#if __ARM_ARCH >= 5 > + this is not enough: v5t and v6 only supports clz in arm mode v6t2 and v7 supports it in thumb mode too. i think we should either check for >= 7 conservatively or check __ARM_FEATURE_CLZ which is defined in https://developer.arm.com/docs/ihi0053/b/arm-c-language-extensions-release-11 > #define a_clz_32 a_clz_32 > static inline int a_clz_32(uint32_t x) > { > __asm__ ("clz %0, %1" : "=r"(x) : "r"(x)); > return x; > } > + > +#endif > -- > 2.15.0.rc1 >