From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Build failure on ARM <5
Date: Fri, 20 Oct 2017 17:26:14 -0400 [thread overview]
Message-ID: <20171020212614.GU1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <20171020193645.GT15263@port70.net>
On Fri, Oct 20, 2017 at 09:36:45PM +0200, Szabolcs Nagy wrote:
> * Reiner Herrmann <reiner@reiner-h.de> [2017-10-20 21:04:00 +0200]:
> > Hi,
> >
> > musl 1.1.17 fails to build [1] on arm versions <5 because
> > of an unsupported clz instruction.
> > The attached patch by Adrian Bunk [2] fixes this issue.
> >
>
> this is my bug sorry,
>
> > diff --git a/arch/arm/atomic_arch.h b/arch/arm/atomic_arch.h
> > index a121010f..c5c56f81 100644
> > --- a/arch/arm/atomic_arch.h
> > +++ b/arch/arm/atomic_arch.h
> > @@ -82,9 +82,13 @@ static inline void a_crash()
> > : : : "memory");
> > }
> >
> > +#if __ARM_ARCH >= 5
> > +
>
> this is not enough: v5t and v6 only supports clz in arm mode
> v6t2 and v7 supports it in thumb mode too.
I don't think this matters yet because thumb1 is not supported at all.
If we support it in the future it will matter, though.
Rich
next prev parent reply other threads:[~2017-10-20 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 19:04 Reiner Herrmann
2017-10-20 19:36 ` Szabolcs Nagy
2017-10-20 21:26 ` Rich Felker [this message]
2017-10-25 16:56 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020212614.GU1627@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).