From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12024 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Build failure on ARM <5 Date: Fri, 20 Oct 2017 17:26:14 -0400 Message-ID: <20171020212614.GU1627@brightrain.aerifal.cx> References: <20171020190400.2vbeywawzh2ompoa@apollo> <20171020193645.GT15263@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1508534803 19379 195.159.176.226 (20 Oct 2017 21:26:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Oct 2017 21:26:43 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-12037-gllmg-musl=m.gmane.org@lists.openwall.com Fri Oct 20 23:26:39 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1e5eoB-0002sG-En for gllmg-musl@m.gmane.org; Fri, 20 Oct 2017 23:26:23 +0200 Original-Received: (qmail 32240 invoked by uid 550); 20 Oct 2017 21:26:27 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 32210 invoked from network); 20 Oct 2017 21:26:27 -0000 Content-Disposition: inline In-Reply-To: <20171020193645.GT15263@port70.net> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:12024 Archived-At: On Fri, Oct 20, 2017 at 09:36:45PM +0200, Szabolcs Nagy wrote: > * Reiner Herrmann [2017-10-20 21:04:00 +0200]: > > Hi, > > > > musl 1.1.17 fails to build [1] on arm versions <5 because > > of an unsupported clz instruction. > > The attached patch by Adrian Bunk [2] fixes this issue. > > > > this is my bug sorry, > > > diff --git a/arch/arm/atomic_arch.h b/arch/arm/atomic_arch.h > > index a121010f..c5c56f81 100644 > > --- a/arch/arm/atomic_arch.h > > +++ b/arch/arm/atomic_arch.h > > @@ -82,9 +82,13 @@ static inline void a_crash() > > : : : "memory"); > > } > > > > +#if __ARM_ARCH >= 5 > > + > > this is not enough: v5t and v6 only supports clz in arm mode > v6t2 and v7 supports it in thumb mode too. I don't think this matters yet because thumb1 is not supported at all. If we support it in the future it will matter, though. Rich