From: Rich Felker <dalias@libc.org>
To: Minqiang Chen <ptpt52@gmail.com>
Cc: musl@lists.openwall.com
Subject: Re: [PATCH v1] mman: fix mmap pass wrong offset to kernel
Date: Sat, 21 Oct 2017 00:20:05 -0400 [thread overview]
Message-ID: <20171021042005.GV1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <94E25077-4463-454D-96BF-BA1DA9166F60@gmail.com>
On Fri, Oct 20, 2017 at 05:06:29PM +0800, Minqiang Chen wrote:
> I don’t know why, but this is how I fix it.
> on arm_cortex-a15 it is 32bit arch
off_t is always 64-bit regardless of whether it's a 32-bit arch. This
is definitely a bug in the calling program, not musl.
> > 在 2017年10月17日，00:27，Rich Felker <dalias@libc.org> 写道：
> >
> > On Mon, Oct 16, 2017 at 01:03:18PM +0200, Szabolcs Nagy wrote:
> >> * Minqiang Chen <ptpt52@gmail.com> [2017-10-16 09:09:32 +0800]:
> >>>
> >>> musl: fix mmap pass wrong offset to kernel
> >>>
> >>>
> >>>
> >>> for example off_t x=0x8d9eb000, the x/4096 result is 0xfff8d9eb,
> >>> not 0x8d9eb as expecting
> >>>
> >>
> >> off_t is 64bit, not 32bit, so x/4096 should not signextend.
> >> you need to investigate this problem more.
> >
> > I suspect the calling code stored the offset 0x8d9eb000 in a signed
> > 32-bit variable (converting it to a negative value) and then passed
> > the resulting negative value to mmap.
> >
> > Rich
>
prev parent reply other threads:[~2017-10-21 4:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 1:09 Minqiang Chen
2017-10-16 11:03 ` Szabolcs Nagy
2017-10-16 16:27 ` Rich Felker
[not found] ` <94E25077-4463-454D-96BF-BA1DA9166F60@gmail.com>
2017-10-21 4:20 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021042005.GV1627@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
--cc=ptpt52@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).