From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: How to handle attempts to combine ARM Thumb with frame pointers?
Date: Wed, 25 Oct 2017 23:16:23 +0200 [thread overview]
Message-ID: <20171025211623.GU15263@port70.net> (raw)
In-Reply-To: <CAJ86T=WNryTRgQ=OOUn0XXy6B03jA0OfD+_DasxbEtTUVGGikw@mail.gmail.com>
* Andre McCurdy <armccurdy@gmail.com> [2017-10-09 09:48:29 -0700]:
> On Sat, Oct 7, 2017 at 8:21 PM, Rich Felker <dalias@libc.org> wrote:
> > On Fri, Oct 06, 2017 at 05:53:38PM -0700, Andre McCurdy wrote:
> > If you do want to test for broken configurations, rather than
> > hard-coding an assumption that some configuration is broken, you
> > should test for it. This would look something like, if ARCH is arm,
> > try compiling a trivial function with inline asm using r7 and see if
> > it fails.
>
> Yes, I came to the same conclusion after seeing the clang bug, which
> seems to suggest that clang uses a frame pointer even with
> optimisation enabled.
>
> > If so, exit with an error or perhaps try adding
> > -fomit-frame-pointer and retrying.
>
> If we over-ride the user supplied CFLAGS then there's probably no need
> to test the behaviour of the compiler - we can just force
> -fomit-frame-pointer unconditionally when compiling for Thumb/Thumb2.
>
> There's a slight complication though that if -fno-omit-frame-pointer
> is present in the user supplied CFLAGS then adding
> -fomit-frame-pointer to CFLAGS_AUTO won't over-ride it (since CFLAGS
> appears on the final compiler command line after CFLAGS_AUTO).
>
> Would it be OK for the configure script to append to CFLAGS? Or should
> the configure script perhaps setup a new variable (CFLAGS_FORCE?)
> which the Makefile would then add to CFLAGS_ALL after CFLAGS?
>
glibc works this around in thumb mode by extern syscall asm
(of course it cannot guarantee that r7 is a frame pointer at
all times, an interrupt can observe r7 with syscall num in it,
i'm not sure if that's acceptable for users who compile with
frame-pointers, in musl there is some asm code which wont
have fp setup anyway).
http://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/arm/sysdep.h;h=6a64351cdd87c2041d639a17efc9f681262d5e3f;hb=HEAD#l335
next prev parent reply other threads:[~2017-10-25 21:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 0:53 Andre McCurdy
2017-10-07 1:24 ` Khem Raj
2017-10-07 1:41 ` Andre McCurdy
2017-10-08 3:21 ` Rich Felker
2017-10-09 16:48 ` Andre McCurdy
2017-10-25 21:16 ` Szabolcs Nagy [this message]
2017-10-26 16:48 ` Adhemerval Zanella
2017-10-26 17:00 ` Rich Felker
2017-10-26 17:48 ` Andre McCurdy
2017-10-26 17:54 ` Rich Felker
2017-10-26 18:51 ` Andre McCurdy
2017-10-27 0:33 ` Rich Felker
2017-10-27 2:17 ` Andre McCurdy
2017-10-28 0:48 ` Andre McCurdy
2017-10-26 18:46 ` Adhemerval Zanella
2017-10-27 0:30 ` Rich Felker
2017-10-27 11:47 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025211623.GU15263@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).