mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: libc-test on aarch64
Date: Tue, 31 Oct 2017 12:50:32 +0100	[thread overview]
Message-ID: <20171031115032.GX15263@port70.net> (raw)
In-Reply-To: <15f7098e490.f6683ec2155112.5721721688095339796@pocketcluster.io>

* Sung-Taek Kim <stkim1@pocketcluster.io> [2017-10-30 21:03:09 -0700]:
> I was able to run Szabolcs' libc-test on aarch64 &amp; x86_64, and aarch64 test produced noticeably more "bad fp exception".
> 
> Being aware of musl's experimental status on aarch64, I'd just like to make sure this is expected.
> 

those tests are wrong and i should fix them.

the current standard allows rounding functions to either
consistently raise inexact or not raise exceptions for
non-integer inputs.  the c code in musl was written so
it raises inexact (following fdlibm convention), and the
tests try to check for that.

but the other way is correct too and ieee754-2008 made
that a requirement and future c fp standard (ts 18661)
will require that too, so eventually both the c code in
musl and the test system should be fixed to check for that.

on aarch64 recently the rounding functions were changed
to use single instruction asm implementation and those
follow the ieee754-2008 requirement.

(fixing this in the c code can be expensive: either int
arithmetics has to be used or the inexact flag has to be
suppressed by modifying the fenv status, both of which
can be significantly slower than the current implementation
on some targets)

that said aarch64 has one outstanding issue: some long
double functions are broken for the 128bit float format.
other than this aarch64 port should work well.

> lib &amp; testsuite version
> 
> - musl : 1.1.7
> 

i assume this is 1.1.17

> - libc-test : commit defcb8 (2017/06/22)
> 
> 
> 
> aarch64 (odroid c2)
> 
> - gcc : (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.5) 5.4.0 20160609
> 
> - kernel : Linux odroid 3.14.79-102
> 


  reply	other threads:[~2017-10-31 11:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31  4:03 Sung-Taek Kim
2017-10-31 11:50 ` Szabolcs Nagy [this message]
2017-11-01  1:03   ` Sung-Taek Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171031115032.GX15263@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).