From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] __lookup_serv: return correct error code
Date: Sun, 5 Nov 2017 19:44:48 -0500 [thread overview]
Message-ID: <20171106004448.GK1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <20170914214817.GV1627@brightrain.aerifal.cx>
On Thu, Sep 14, 2017 at 05:48:17PM -0400, Rich Felker wrote:
> On Thu, Sep 14, 2017 at 03:53:21PM -0500, A. Wilcox wrote:
> > From: "A. Wilcox" <AWilcox@Wilcox-Tech.com>
> >
> > If AI_NUMERICSERV is specified and a numeric service was not provided,
> > POSIX mandates getaddrinfo return EAI_NONAME. EAI_SERVICE is only for
> > services that cannot be used on the specified socket type.
> > ---
> > src/network/lookup_serv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/network/lookup_serv.c b/src/network/lookup_serv.c
> > index 66ebaea..403b12a 100644
> > --- a/src/network/lookup_serv.c
> > +++ b/src/network/lookup_serv.c
> > @@ -64,7 +64,7 @@ int __lookup_serv(struct service buf[static MAXSERVS], const char *name, int pro
> > return cnt;
> > }
> >
> > - if (flags & AI_NUMERICSERV) return EAI_SERVICE;
> > + if (flags & AI_NUMERICSERV) return EAI_NONAME;
> >
> > size_t l = strlen(name);
> >
> > --
> > 2.10.0
>
> I think you've uncovered a larger bug than the patch fixes; it looks
> like most of the EAI_SERVICE return points in __lookup_serv are wrong.
> Most should probably be EAI_NONAME; a couple should possibly be
> EAI_SOCKTYPE. Thoughts?
On further consideration, "AI_NUMERICSERV was specified and the
argument is not a numeric string" seems like the only case that
explicitly mandates EAI_NONAME. Specification of EAI_SERVICE is really
ambiguous/underspecified though. The patch is probably okay as-is.
Rich
prev parent reply other threads:[~2017-11-06 0:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 20:53 A. Wilcox
2017-09-14 21:48 ` Rich Felker
2017-11-06 0:44 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106004448.GK1627@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).