From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12063 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] __lookup_serv: return correct error code Date: Sun, 5 Nov 2017 19:44:48 -0500 Message-ID: <20171106004448.GK1627@brightrain.aerifal.cx> References: <20170914205321.18733-1-awilfox@adelielinux.org> <20170914214817.GV1627@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1509929104 17481 195.159.176.226 (6 Nov 2017 00:45:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 6 Nov 2017 00:45:04 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-12079-gllmg-musl=m.gmane.org@lists.openwall.com Mon Nov 06 01:45:00 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1eBVX9-0004KR-I3 for gllmg-musl@m.gmane.org; Mon, 06 Nov 2017 01:44:59 +0100 Original-Received: (qmail 9591 invoked by uid 550); 6 Nov 2017 00:45:03 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 9556 invoked from network); 6 Nov 2017 00:45:02 -0000 Content-Disposition: inline In-Reply-To: <20170914214817.GV1627@brightrain.aerifal.cx> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:12063 Archived-At: On Thu, Sep 14, 2017 at 05:48:17PM -0400, Rich Felker wrote: > On Thu, Sep 14, 2017 at 03:53:21PM -0500, A. Wilcox wrote: > > From: "A. Wilcox" > > > > If AI_NUMERICSERV is specified and a numeric service was not provided, > > POSIX mandates getaddrinfo return EAI_NONAME. EAI_SERVICE is only for > > services that cannot be used on the specified socket type. > > --- > > src/network/lookup_serv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/network/lookup_serv.c b/src/network/lookup_serv.c > > index 66ebaea..403b12a 100644 > > --- a/src/network/lookup_serv.c > > +++ b/src/network/lookup_serv.c > > @@ -64,7 +64,7 @@ int __lookup_serv(struct service buf[static MAXSERVS], const char *name, int pro > > return cnt; > > } > > > > - if (flags & AI_NUMERICSERV) return EAI_SERVICE; > > + if (flags & AI_NUMERICSERV) return EAI_NONAME; > > > > size_t l = strlen(name); > > > > -- > > 2.10.0 > > I think you've uncovered a larger bug than the patch fixes; it looks > like most of the EAI_SERVICE return points in __lookup_serv are wrong. > Most should probably be EAI_NONAME; a couple should possibly be > EAI_SOCKTYPE. Thoughts? On further consideration, "AI_NUMERICSERV was specified and the argument is not a numeric string" seems like the only case that explicitly mandates EAI_NONAME. Specification of EAI_SERVICE is really ambiguous/underspecified though. The patch is probably okay as-is. Rich