From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12074 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Add SOCK_STREAM support for syslog Date: Fri, 10 Nov 2017 12:14:06 -0500 Message-ID: <20171110171406.GQ1627@brightrain.aerifal.cx> References: <1510319851.23177.3.camel@mittwald.de> <20171110140749.GC15263@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1510334063 12283 195.159.176.226 (10 Nov 2017 17:14:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Nov 2017 17:14:23 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-12090-gllmg-musl=m.gmane.org@lists.openwall.com Fri Nov 10 18:14:17 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1eDCsi-0002xJ-2F for gllmg-musl@m.gmane.org; Fri, 10 Nov 2017 18:14:16 +0100 Original-Received: (qmail 32180 invoked by uid 550); 10 Nov 2017 17:14:20 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 32156 invoked from network); 10 Nov 2017 17:14:20 -0000 Content-Disposition: inline In-Reply-To: <20171110140749.GC15263@port70.net> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:12074 Archived-At: On Fri, Nov 10, 2017 at 03:07:49PM +0100, Szabolcs Nagy wrote: > * Jan Horstmann [2017-11-10 13:17:31 +0000]: > > some time ago there was a discussion whether musl-libc's syslog should > > support SOCK_STREAM as a fall back if SOCK_DGRAM fails like glibc does > > ( http://www.openwall.com/lists/musl/2015/08/10/1 ) > > Later on a patch was posted to the mailing list: http://www.openwall.com/lists/musl/2017/08/21/3 > > Since we depend on this functionality we have applied this patch and are quiet happy with it. > > I would like to know whether there are any plans to incorporate this patch into a future release? > > i think you need to explain why you depend on this > to get consensus on the inclusion of the patch. Is it mutually exclusive whether /dev/log is listening as SOCK_DGRAM or SOCK_STREAM? If not, I think there's a race where connecting to SOCK_DGRAM fails, then syslogd starts listening on both, and the SOCK_STREAM connect succeeds in the fallback despite there being a SOCK_DGRAM service available. Adoption of the patch is mainly blocked on establishing that it does not harm any existing usage. I suspect and seem to remember (but haven't looked at it lately) that SOCK_STREAM has some undesirable properties from a standpoint of logging and that SOCK_DGRAM is what you want if possible. Rich