From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12200 Path: news.gmane.org!.POSTED!not-for-mail From: Jo-Philipp Wich Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] nameser.h: explicitely include endian.h Date: Mon, 4 Dec 2017 11:55:48 +0100 Message-ID: <20171204105548.2576-1-jo@mein.io> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1512388418 28755 195.159.176.226 (4 Dec 2017 11:53:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 4 Dec 2017 11:53:38 +0000 (UTC) Cc: Jo-Philipp Wich To: musl@lists.openwall.com Original-X-From: musl-return-12216-gllmg-musl=m.gmane.org@lists.openwall.com Mon Dec 04 12:53:33 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1eLpJR-00075M-Qo for gllmg-musl@m.gmane.org; Mon, 04 Dec 2017 12:53:29 +0100 Original-Received: (qmail 1626 invoked by uid 550); 4 Dec 2017 11:53:34 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 19489 invoked from network); 4 Dec 2017 10:56:06 -0000 X-Mailer: git-send-email 2.11.0 Xref: news.gmane.org gmane.linux.lib.musl.general:12200 Archived-At: As nameser.h itself uses endian macros to declare the proper layout of the HEADER structure, it needs to include the endian.h header as well. The issue was found while investigating iodine query packet corruption on little endian musl systems [1]. 1: http://lists.infradead.org/pipermail/lede-dev/2017-November/010085.html Signed-off-by: Jo-Philipp Wich --- include/arpa/nameser.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/arpa/nameser.h b/include/arpa/nameser.h index 581925a4..b315e0f3 100644 --- a/include/arpa/nameser.h +++ b/include/arpa/nameser.h @@ -7,6 +7,7 @@ extern "C" { #include #include +#include #define __NAMESER 19991006 #define NS_PACKETSZ 512 -- 2.11.0