Re: [PATCH] implement strftime GNU extension padding specifiers '_', '-' and '0'

[Rich Felker <dalias@libc.org>]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

On Sat, Dec 09, 2017 at 05:56:50PM -0500, Rich Felker wrote:
> If you're tired of working and waiting on this and just want me to
> commit it as-is and make any improvements later, just let me know.
> I'll try to adapt the (freeform, non-checking) tests I did into
> something that can go into libc-test.

Attached is my first draft of what could go in libc-test. It doesn't
cover any subtleties of value computation, only formatting.

Rich

[-- Attachment #2: strftime.c --]
[-- Type: text/plain, Size: 1732 bytes --]

#include <stdio.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include "test.h"

#define T1 3724

static const struct {
	time_t t;
	const char *fmt;
	const char *expect;
} tests[] = {
	{ T1, "%a", "Thu" },
	{ T1, "%A", "Thursday" },
	{ T1, "%b", "Jan" },
	{ T1, "%B", "January" },
	{ T1, "%c", "Thu Jan  1 01:02:04 1970" },
	{ T1, "%C", "19" },
	{ T1, "%04C", "0019" },
	//{ T1, "%+4C", "0019" }, // correct?
	{ T1, "%d", "01" },
	{ T1, "%D", "01/01/70" },
	{ T1, "%e", " 1" },
	{ T1, "%F", "1970-01-01" },
	{ T1, "%012F", "001970-01-01" },
	// { T1, "%+12F", "001970-01-01" }, //correct?
	{ T1, "%g", "70" },
	{ T1, "%G", "1970" },
	{ T1, "%06G", "001970" },
	// { T1, "%+6G", "001970" }, // correct?
	{ T1, "%h", "Jan" },
	{ T1, "%H", "01" },
	{ T1, "%I", "01" },
	{ T1, "%j", "001" },
	{ T1, "%m", "01" },
	{ T1, "%M", "02" },
	{ T1, "%n", "\n" },
	{ T1, "%p", "AM" },
	{ T1, "%r", "01:02:04 AM" },
	{ T1, "%R", "01:02" },
	{ T1, "%s", "3724" },
	{ T1, "%S", "04" },
	{ T1, "%T", "01:02:04" },
	{ T1, "%u", "4" },
	{ T1, "%U", "00" },
	{ T1, "%V", "01" },
	{ T1, "%w", "4" },
	{ T1, "%W", "00" },
	{ T1, "%x", "01/01/70" },
	{ T1, "%X", "01:02:04" },
	{ T1, "%Y", "1970" },
	{ T1, "%06Y", "001970" },
	// { T1, "%+6Y", "001970" }, //correct ?
};

int main(int argc, char **argv)
{
	for (size_t i=0; i<sizeof tests/sizeof *tests; i++) {
		time_t t = tests[i].t;
		struct tm *tm = gmtime(&t);
		char buf[500];
		size_t n = strftime(buf, sizeof buf, tests[i].fmt, tm);
		size_t l = strlen(tests[i].expect);
		if (n != l)
			t_error("strftime returned %zu expected %zu\n", n, l);
		if (n && strcmp(buf, tests[i].expect))
			t_error("strftime wrote '%s' expected '%s'\n", buf, tests[i].expect);
	}

	return t_status;
}