From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12241 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] nameser.h: explicitely include endian.h Date: Thu, 14 Dec 2017 23:38:48 -0500 Message-ID: <20171215043848.GJ1627@brightrain.aerifal.cx> References: <20171204111306.2859-1-jo@mein.io> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1513312740 14980 195.159.176.226 (15 Dec 2017 04:39:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 15 Dec 2017 04:39:00 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-12257-gllmg-musl=m.gmane.org@lists.openwall.com Fri Dec 15 05:38:56 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1ePhlv-0003ej-Mc for gllmg-musl@m.gmane.org; Fri, 15 Dec 2017 05:38:55 +0100 Original-Received: (qmail 26020 invoked by uid 550); 15 Dec 2017 04:39:00 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 25997 invoked from network); 15 Dec 2017 04:39:00 -0000 Content-Disposition: inline In-Reply-To: <20171204111306.2859-1-jo@mein.io> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:12241 Archived-At: On Mon, Dec 04, 2017 at 12:13:06PM +0100, Jo-Philipp Wich wrote: > As nameser.h itself uses endian macros to declare the proper layout of > the HEADER structure, it needs to include the endian.h header as well. > > The issue was found while investigating iodine query packet corruption > on little endian musl systems [1]. > > 1: http://lists.infradead.org/pipermail/lede-dev/2017-November/010085.html > > Signed-off-by: Jo-Philipp Wich > --- > include/arpa/nameser.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/arpa/nameser.h b/include/arpa/nameser.h > index 581925a4..b315e0f3 100644 > --- a/include/arpa/nameser.h > +++ b/include/arpa/nameser.h > @@ -7,6 +7,7 @@ extern "C" { > > #include > #include > +#include > > #define __NAMESER 19991006 > #define NS_PACKETSZ 512 > -- > 2.11.0 Thanks. Committing. Rich