From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12252 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] nameser.h: explicitely include endian.h Date: Fri, 15 Dec 2017 12:57:21 -0500 Message-ID: <20171215175721.GN1627@brightrain.aerifal.cx> References: <20171204111306.2859-1-jo@mein.io> <20171215043848.GJ1627@brightrain.aerifal.cx> <976700e2-b63d-7c75-21fa-136e3cf5a9a6@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1513360654 31765 195.159.176.226 (15 Dec 2017 17:57:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 15 Dec 2017 17:57:34 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-12268-gllmg-musl=m.gmane.org@lists.openwall.com Fri Dec 15 18:57:29 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1ePuEi-00083Q-FO for gllmg-musl@m.gmane.org; Fri, 15 Dec 2017 18:57:28 +0100 Original-Received: (qmail 24419 invoked by uid 550); 15 Dec 2017 17:57:34 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 24396 invoked from network); 15 Dec 2017 17:57:33 -0000 Content-Disposition: inline In-Reply-To: <976700e2-b63d-7c75-21fa-136e3cf5a9a6@gmail.com> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:12252 Archived-At: On Fri, Dec 15, 2017 at 06:54:10PM +0100, Bartosz Brachaczek wrote: > On 12/15/2017 5:38 AM, Rich Felker wrote: > >On Mon, Dec 04, 2017 at 12:13:06PM +0100, Jo-Philipp Wich wrote: > >>As nameser.h itself uses endian macros to declare the proper layout of > >>the HEADER structure, it needs to include the endian.h header as well. > >> > >>The issue was found while investigating iodine query packet corruption > >>on little endian musl systems [1]. > >> > >>1: http://lists.infradead.org/pipermail/lede-dev/2017-November/010085.html > >> > >>Signed-off-by: Jo-Philipp Wich > >>--- > >> include/arpa/nameser.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >>diff --git a/include/arpa/nameser.h b/include/arpa/nameser.h > >>index 581925a4..b315e0f3 100644 > >>--- a/include/arpa/nameser.h > >>+++ b/include/arpa/nameser.h > >>@@ -7,6 +7,7 @@ extern "C" { > >> #include > >> #include > >>+#include > >> #define __NAMESER 19991006 > >> #define NS_PACKETSZ 512 > >>-- > >>2.11.0 > > > >Thanks. Committing. > > I believe include/netinet/icmp6.h suffers from the same issue > (missing endian.h include directive). Thanks. I'll check and fix if this is the case. Rich