From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] nameser.h: explicitely include endian.h
Date: Fri, 15 Dec 2017 13:53:36 -0500 [thread overview]
Message-ID: <20171215185336.GO1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <20171215175721.GN1627@brightrain.aerifal.cx>
On Fri, Dec 15, 2017 at 12:57:21PM -0500, Rich Felker wrote:
> On Fri, Dec 15, 2017 at 06:54:10PM +0100, Bartosz Brachaczek wrote:
> > On 12/15/2017 5:38 AM, Rich Felker wrote:
> > >On Mon, Dec 04, 2017 at 12:13:06PM +0100, Jo-Philipp Wich wrote:
> > >>As nameser.h itself uses endian macros to declare the proper layout of
> > >>the HEADER structure, it needs to include the endian.h header as well.
> > >>
> > >>The issue was found while investigating iodine query packet corruption
> > >>on little endian musl systems [1].
> > >>
> > >>1: http://lists.infradead.org/pipermail/lede-dev/2017-November/010085.html
> > >>
> > >>Signed-off-by: Jo-Philipp Wich <jo@mein.io>
> > >>---
> > >> include/arpa/nameser.h | 1 +
> > >> 1 file changed, 1 insertion(+)
> > >>
> > >>diff --git a/include/arpa/nameser.h b/include/arpa/nameser.h
> > >>index 581925a4..b315e0f3 100644
> > >>--- a/include/arpa/nameser.h
> > >>+++ b/include/arpa/nameser.h
> > >>@@ -7,6 +7,7 @@ extern "C" {
> > >> #include <stddef.h>
> > >> #include <stdint.h>
> > >>+#include <endian.h>
> > >> #define __NAMESER 19991006
> > >> #define NS_PACKETSZ 512
> > >>--
> > >>2.11.0
> > >
> > >Thanks. Committing.
> >
> > I believe include/netinet/icmp6.h suffers from the same issue
> > (missing endian.h include directive).
>
> Thanks. I'll check and fix if this is the case.
Fixed (pending push). I also grepped and didn't find any other headers
that include "BYTE_ORDER" but not "endian.h".
Rich
next prev parent reply other threads:[~2017-12-15 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 11:13 Jo-Philipp Wich
2017-12-15 4:38 ` Rich Felker
2017-12-15 17:54 ` Bartosz Brachaczek
2017-12-15 17:57 ` Rich Felker
2017-12-15 18:53 ` Rich Felker [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-04 10:55 Jo-Philipp Wich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215185336.GO1627@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).