From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12298 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Add getrandom syscall wrapper function Date: Mon, 1 Jan 2018 17:03:54 -0500 Message-ID: <20180101220354.GI1627@brightrain.aerifal.cx> References: <20180101203123.12816-1-hauke@hauke-m.de> <20180101204748.GH1627@brightrain.aerifal.cx> <501306ff-c0e3-f1be-a81b-ba6e619fd807@hauke-m.de> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1514844136 29329 195.159.176.226 (1 Jan 2018 22:02:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 1 Jan 2018 22:02:16 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-12314-gllmg-musl=m.gmane.org@lists.openwall.com Mon Jan 01 23:02:11 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1eW89q-0006ub-A6 for gllmg-musl@m.gmane.org; Mon, 01 Jan 2018 23:02:10 +0100 Original-Received: (qmail 7411 invoked by uid 550); 1 Jan 2018 22:04:06 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 7393 invoked from network); 1 Jan 2018 22:04:06 -0000 Content-Disposition: inline In-Reply-To: <501306ff-c0e3-f1be-a81b-ba6e619fd807@hauke-m.de> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:12298 Archived-At: On Mon, Jan 01, 2018 at 10:51:34PM +0100, Hauke Mehrtens wrote: > On 01/01/2018 09:47 PM, Rich Felker wrote: > > On Mon, Jan 01, 2018 at 09:31:23PM +0100, Hauke Mehrtens wrote: > >> This syscall is available since Linux 3.17 and was also implemented in > >> glibc in version 2.25. This is a pure syscall wrapper liker glibc does > >> it. > >> --- > >> include/sys/random.h | 19 +++++++++++++++++++ > >> src/linux/getrandom.c | 11 +++++++++++ > >> 2 files changed, 30 insertions(+) > >> create mode 100644 include/sys/random.h > >> create mode 100644 src/linux/getrandom.c > >> > >> diff --git a/include/sys/random.h b/include/sys/random.h > >> new file mode 100644 > >> index 00000000..5540f877 > >> --- /dev/null > >> +++ b/include/sys/random.h > >> @@ -0,0 +1,19 @@ > >> +#ifndef _SYS_RANDOM_H > >> +#define _SYS_RANDOM_H > >> +#ifdef __cplusplus > >> +extern "C" { > >> +#endif > >> + > >> +#define __NEED_size_t > >> +#define __NEED_ssize_t > >> +#include > >> + > >> +#define GRND_NONBLOCK 0x0001 > >> +#define GRND_RANDOM 0x0002 > >> + > >> +ssize_t getrandom(void *buf, size_t buflen, unsigned int flags); > >> + > >> +#ifdef __cplusplus > >> +} > >> +#endif > >> +#endif > >> diff --git a/src/linux/getrandom.c b/src/linux/getrandom.c > >> new file mode 100644 > >> index 00000000..50b07df9 > >> --- /dev/null > >> +++ b/src/linux/getrandom.c > >> @@ -0,0 +1,11 @@ > >> +#include > >> +#include "syscall.h" > >> + > >> +ssize_t getrandom(void *buf, size_t buflen, unsigned int flags) > >> +{ > >> +#ifdef SYS_getrandom > >> + return syscall_cp(SYS_getrandom, buf, buflen, flags); > >> +#else > >> + return __syscall_ret(-ENOSYS); > >> +#endif > >> +} > >> -- > >> 2.11.0 > > > > The #ifdef doesn't make sense; if the definition is missing then it's > > a bug in musl source. > > Ok, If I can assume that SYS_getrandom is always defined I will remove this. > > > Aside from that I think the patch is okay but I'm not sure it's > > complete. There should probably also be getentropy(), > > Adding getentropy() should not be so hard, I can do that. > > > and we've > > discussed in the past but never reached any conclusion on whether > > there should be a fallback when the syscall doesn't exist (running on > > old kernel). > > glibc does not have a fallback for this syscall there was a long > discussion about this, see here: https://lwn.net/Articles/711013/ > As they never found a good solution for their fallback. I think musl > should also not provide a fallback. > > This is the glibc implementation: > https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=92dcaa3e2f7bf0f7f1c04cd2fb6a317df1a4e225 I think we can add it for now with no fallback to unblock things waiting on it, and also consider adding fallback. If/when we add arc4random/posix_random, we will have a perfectly reasonable backend we can use in the absence of the syscall. It would initialize its entropy from AT_RANDOM on kernels that have it and from the legacy sysctl random source on kernels too old to have AT_RANDOM. Rich