From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: a third bug in musl clone()
Date: Tue, 2 Jan 2018 21:51:30 -0500 [thread overview]
Message-ID: <20180103025130.GO1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <e4cd8c3d-24eb-c467-d337-2ef89c7d65b4@redhat.com>
On Tue, Jan 02, 2018 at 11:09:24PM +0100, Florian Weimer wrote:
> On 01/02/2018 08:58 PM, Rich Felker wrote:
> >In any case it should be fixed by checking flags.
>
> I think this would be worse than the cure because it results in
> subtle bugs if the kernel adds more flags which require different
> argument counts. We saw that with O_TMPFILE and open/openat.
Wasn't that just a bug with O_TMPFILE having implicit O_CREAT but not
having the actual O_CREAT bit set in its value? I understand the
sentiment here but I think if we're really worried about that we could
just fail with EINVAL for unknown flags (requiring a sufficiently new
libc.so to be aware of the flags) rather than leaving the UB in place.
Rich
prev parent reply other threads:[~2018-01-03 2:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-23 9:45 [PATCH] Add comments to i386 assembly source Markus Wichmann
2017-12-31 4:15 ` John Reiser
2017-12-31 6:54 ` Markus Wichmann
2017-12-31 15:49 ` Rich Felker
2018-01-01 19:52 ` Markus Wichmann
2018-01-01 22:57 ` John Reiser
2018-01-02 1:49 ` Rich Felker
2018-01-02 3:15 ` John Reiser
2018-01-02 19:49 ` Rich Felker
2018-01-02 18:24 ` a third bug in musl clone() John Reiser
2018-01-02 19:58 ` Rich Felker
2018-01-02 22:09 ` Florian Weimer
2018-01-03 2:51 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103025130.GO1627@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).