From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12318 Path: news.gmane.org!.POSTED!not-for-mail From: Jens Gustedt Newsgroups: gmane.linux.lib.musl.general Subject: automated coding style Date: Wed, 3 Jan 2018 15:08:33 +0100 Organization: inria.fr Message-ID: <20180103150833.3fe810e6@inria.fr> References: <20171220215827.GW1627@brightrain.aerifal.cx> <20171221120655.5929ec56@inria.fr> <20171221233402.GZ1627@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/GrmxEecJjlm61yNZOm0JswH"; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1514988414 18638 195.159.176.226 (3 Jan 2018 14:06:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 3 Jan 2018 14:06:54 +0000 (UTC) Cc: musl@lists.openwall.com Original-X-From: musl-return-12334-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jan 03 15:06:50 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1eWjgs-0004KS-Eq for gllmg-musl@m.gmane.org; Wed, 03 Jan 2018 15:06:46 +0100 Original-Received: (qmail 31936 invoked by uid 550); 3 Jan 2018 14:08:46 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 31877 invoked from network); 3 Jan 2018 14:08:45 -0000 X-IronPort-AV: E=Sophos;i="5.45,501,1508796000"; d="scan'208";a="307525063" In-Reply-To: <20171221233402.GZ1627@brightrain.aerifal.cx> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) X-Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAACRQTFRFERslNjAsLTE9Ok9wUk9TaUs8iWhSrYZkj42Rz6aD3sGZ Xref: news.gmane.org gmane.linux.lib.musl.general:12318 Archived-At: --Sig_/GrmxEecJjlm61yNZOm0JswH Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hello Rich, On Thu, 21 Dec 2017 18:34:02 -0500 Rich Felker wrote: > On Thu, Dec 21, 2017 at 12:06:55PM +0100, Jens Gustedt wrote: > > > There seems to be some mixing of tabs and spaces here and in a few > > > other lines. Tabs should be used for indentation levels, spaces > > > (after any initial indent) to column-align. Generally musl style > > > also has continuation comment lines begin with a * aligned with > > > the * of the opening /* too. =20 > >=20 > > Since I ran into similar comments before and I find it quite > > frustrating and disruptive: =20 >=20 > By similar comments do you mean existing comments in the musl source > styled like you did it, or similar email comments before about styling > matters? comments about style. it think an automatic formatting procedure that accommodates everybody could help us focus on contents > I'm not familiar with these tools, so I could look into it, but > someone else interested might be able to get to it before me. I'll > see. The way I deal with touching code in lots of different projects > with different styles is having my editor configured to copy exactly > the leading whitespace of the previous line when adding a new line, > and then adding or deleting tabs or spaces as appropriate. But I can > see how that's not agreeable to everyone. >=20 > Actually now that I think about it, I'm pretty sure the official Linux > kernel style is nearly the same as preferred style in musl, and should > usually produce formatting that's perfectly acceptable. so for my latest patches I experimented with astyle --style=3Dlinux --indent=3Dtab This helps a lot, already. Unfortunately, this combination still changes some musl sources, basically because indentation of continuation lines is handled differently. Thanks Jens --=20 :: INRIA Nancy Grand Est ::: Camus ::::::: ICube/ICPS ::: :: ::::::::::::::: office Strasbourg : +33 368854536 :: :: :::::::::::::::::::::: gsm France : +33 651400183 :: :: ::::::::::::::: gsm international : +49 15737185122 :: :: http://icube-icps.unistra.fr/index.php/Jens_Gustedt :: --Sig_/GrmxEecJjlm61yNZOm0JswH Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSN9stI2OFN1pLljN0P0+hp2tU34gUCWkzj4QAKCRAP0+hp2tU3 4rnmAJ9NpAQEJ1E0fV7IvUzF24uD8B75NQCdHAMjJboCDceZUPVFAwJgbIeOqjM= =d17I -----END PGP SIGNATURE----- --Sig_/GrmxEecJjlm61yNZOm0JswH--