From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12348 Path: news.gmane.org!.POSTED!not-for-mail From: Jens Gustedt Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 5/7] use the new lock algorithm for malloc Date: Tue, 9 Jan 2018 19:58:51 +0100 Organization: inria.fr Message-ID: <20180109195851.56c43392@inria.fr> References: <163ca89d544cffbaba5fcfbacf56fb589fd2b03a.1514985618.git.Jens.Gustedt@inria.fr> <20180109174234.GA1627@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/9Xc.hjHypzbSfcIdnDu9bKl"; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1515524229 29078 195.159.176.226 (9 Jan 2018 18:57:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 9 Jan 2018 18:57:09 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-12364-gllmg-musl=m.gmane.org@lists.openwall.com Tue Jan 09 19:57:05 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1eYz56-0007Gx-Bi for gllmg-musl@m.gmane.org; Tue, 09 Jan 2018 19:57:04 +0100 Original-Received: (qmail 5175 invoked by uid 550); 9 Jan 2018 18:59:04 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 5141 invoked from network); 9 Jan 2018 18:59:03 -0000 X-IronPort-AV: E=Sophos;i="5.46,336,1511823600"; d="scan'208";a="308324985" In-Reply-To: <20180109174234.GA1627@brightrain.aerifal.cx> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) X-Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAACRQTFRFERslNjAsLTE9Ok9wUk9TaUs8iWhSrYZkj42Rz6aD3sGZ Xref: news.gmane.org gmane.linux.lib.musl.general:12348 Archived-At: --Sig_/9Xc.hjHypzbSfcIdnDu9bKl Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hello Rich, On Tue, 9 Jan 2018 12:42:34 -0500 Rich Felker wrote: > On Wed, Jan 03, 2018 at 02:17:12PM +0100, Jens Gustedt wrote: > > Malloc used a specialized lock implementation in many places. Now > > that we have a generic lock that has the desired properties, we > > should just use this, instead of this multitude of very similar > > lock mechanisms. --- > > src/malloc/malloc.c | 38 +++++++++++++------------------------- > > 1 file changed, 13 insertions(+), 25 deletions(-) > >=20 > > diff --git a/src/malloc/malloc.c b/src/malloc/malloc.c > > index 9e05e1d6..6c667a5a 100644 > > --- a/src/malloc/malloc.c > > +++ b/src/malloc/malloc.c > > @@ -13,6 +13,8 @@ > > #define inline inline __attribute__((always_inline)) > > #endif > > =20 > > +#include "__lock.h" > > + =20 >=20 > Ah, I see -- maybe you deemed malloc to be the only place where > inlining for the sake of speed made sense? That's probably true. Yes, and also I was trying to be conservative. Previously, the lock functions for malloc resided in the same TU, so they were probably inlined most of the time. Jens --=20 :: INRIA Nancy Grand Est ::: Camus ::::::: ICube/ICPS ::: :: ::::::::::::::: office Strasbourg : +33 368854536 :: :: :::::::::::::::::::::: gsm France : +33 651400183 :: :: ::::::::::::::: gsm international : +49 15737185122 :: :: http://icube-icps.unistra.fr/index.php/Jens_Gustedt :: --Sig_/9Xc.hjHypzbSfcIdnDu9bKl Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSN9stI2OFN1pLljN0P0+hp2tU34gUCWlUQ6wAKCRAP0+hp2tU3 4r41AJ0SNZ7qJ16fDD5TPtzHrNW6k6gD7ACggRCcO0WMyG0YX1TIiXU7kxtvYQ8= =07OT -----END PGP SIGNATURE----- --Sig_/9Xc.hjHypzbSfcIdnDu9bKl--