From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12356 Path: news.gmane.org!.POSTED!not-for-mail From: Jens Gustedt Newsgroups: gmane.linux.lib.musl.general Subject: Re: alternative form flag with zero octal value Date: Thu, 11 Jan 2018 09:12:29 +0100 Organization: inria.fr Message-ID: <20180111091229.3482569b@inria.fr> References: <20180111114305.GG1268@lucy.localdomain> <20180111020246.GG1627@brightrain.aerifal.cx> <20180111021750.GH1627@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/TZ.2bKc12OP.C7XLl2Y.Sk3"; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1515658261 27983 195.159.176.226 (11 Jan 2018 08:11:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 Jan 2018 08:11:01 +0000 (UTC) Cc: musl@lists.openwall.com Original-X-From: musl-return-12372-gllmg-musl=m.gmane.org@lists.openwall.com Thu Jan 11 09:10:57 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1eZXwj-0006E7-Vf for gllmg-musl@m.gmane.org; Thu, 11 Jan 2018 09:10:46 +0100 Original-Received: (qmail 20377 invoked by uid 550); 11 Jan 2018 08:12:46 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 20359 invoked from network); 11 Jan 2018 08:12:46 -0000 X-IronPort-AV: E=Sophos;i="5.46,343,1511823600"; d="scan'208";a="308551111" In-Reply-To: <20180111021750.GH1627@brightrain.aerifal.cx> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) X-Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAACRQTFRFERslNjAsLTE9Ok9wUk9TaUs8iWhSrYZkj42Rz6aD3sGZ Xref: news.gmane.org gmane.linux.lib.musl.general:12356 Archived-At: --Sig_/TZ.2bKc12OP.C7XLl2Y.Sk3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hello, seeing this patch, I am somewhat horrified by the coding style that is applied in that file. Comma operator, seriously? Conditionals without proper indentation? "else" at the end of a line and the depending statement in the next case? If have nothing against clever use of switch cases for such complicated case analysis, but the coding style should prominently make this clear and not obfuscate. Thanks Jens --=20 :: INRIA Nancy Grand Est ::: Camus ::::::: ICube/ICPS ::: :: ::::::::::::::: office Strasbourg : +33 368854536 :: :: :::::::::::::::::::::: gsm France : +33 651400183 :: :: ::::::::::::::: gsm international : +49 15737185122 :: :: http://icube-icps.unistra.fr/index.php/Jens_Gustedt :: --Sig_/TZ.2bKc12OP.C7XLl2Y.Sk3 Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSN9stI2OFN1pLljN0P0+hp2tU34gUCWlccbQAKCRAP0+hp2tU3 4ksCAKCAhXNGSSFA2HDdFU1nK0DJjcr0IgCfTIQs1vAgKa8knYB7F+K+WPd9OSs= =Al/1 -----END PGP SIGNATURE----- --Sig_/TZ.2bKc12OP.C7XLl2Y.Sk3--