From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: alternative form flag with zero octal value
Date: Thu, 11 Jan 2018 13:55:34 -0500 [thread overview]
Message-ID: <20180111185534.GI1627@brightrain.aerifal.cx> (raw)
In-Reply-To: <20180111091229.3482569b@inria.fr>
On Thu, Jan 11, 2018 at 09:12:29AM +0100, Jens Gustedt wrote:
> Hello,
> seeing this patch, I am somewhat horrified by the coding style that is
> applied in that file.
>
> Comma operator, seriously? Conditionals without proper indentation?
> "else" at the end of a line and the depending statement in the next
> case?
>
> If have nothing against clever use of switch cases for such
> complicated case analysis, but the coding style should prominently
> make this clear and not obfuscate.
Yes, there is a good deal of stuff in that file that, in hindsight, I
would do somewhat differently. A few of the worst things you noted
could be 'fixed' trivially with gotos or compound statatements and
probably should be. I don't want a big patch for this file that's hard
to review/validate though; the return on time spent is just too small.
If anyone does want to push me on making improvements here, small
isolated/individual changes that can easily be seen to be correct are
the way to go.
Rich
next prev parent reply other threads:[~2018-01-11 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 0:43 Peter Wang
2018-01-11 2:02 ` Rich Felker
2018-01-11 2:17 ` Rich Felker
2018-01-11 8:12 ` Jens Gustedt
2018-01-11 18:55 ` Rich Felker [this message]
2018-01-11 19:36 ` Jens Gustedt
2018-01-12 0:38 ` Rich Felker
2018-01-12 8:54 ` Jens Gustedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111185534.GI1627@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).