From: Jens Gustedt <jens.gustedt@inria.fr>
Cc: musl@lists.openwall.com
Subject: Re: alternative form flag with zero octal value
Date: Thu, 11 Jan 2018 20:36:23 +0100 [thread overview]
Message-ID: <20180111203623.77269b94@inria.fr> (raw)
In-Reply-To: <20180111185534.GI1627@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]
Hello Rich,
On Thu, 11 Jan 2018 13:55:34 -0500 Rich Felker <dalias@libc.org> wrote:
> Yes, there is a good deal of stuff in that file that, in hindsight, I
> would do somewhat differently. A few of the worst things you noted
> could be 'fixed' trivially with gotos
No, I don't think this is necessary. I don't mind jumping in the
middle of an "if (0)" branch, as long as it is indented correcly :)
> or compound statatements and
> probably should be. I don't want a big patch for this file that's hard
> to review/validate though; the return on time spent is just too small.
> If anyone does want to push me on making improvements here, small
> isolated/individual changes that can easily be seen to be correct are
> the way to go.
Just a patch for white space and indentation would be easy, I think.
- have break at the end of case lines, not at the start
- start a newline before else
- ident according to musl's coding style
As long as git diff --color-words shows nothing, this should be fine.
I could such a patch, if you want.
Replacing comma operators by compound statements would be a bit more
work. We could delay that to when somebody touches that file for more
serious reasons.
Jens
--
:: INRIA Nancy Grand Est ::: Camus ::::::: ICube/ICPS :::
:: ::::::::::::::: office Strasbourg : +33 368854536 ::
:: :::::::::::::::::::::: gsm France : +33 651400183 ::
:: ::::::::::::::: gsm international : +49 15737185122 ::
:: http://icube-icps.unistra.fr/index.php/Jens_Gustedt ::
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2018-01-11 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 0:43 Peter Wang
2018-01-11 2:02 ` Rich Felker
2018-01-11 2:17 ` Rich Felker
2018-01-11 8:12 ` Jens Gustedt
2018-01-11 18:55 ` Rich Felker
2018-01-11 19:36 ` Jens Gustedt [this message]
2018-01-12 0:38 ` Rich Felker
2018-01-12 8:54 ` Jens Gustedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111203623.77269b94@inria.fr \
--to=jens.gustedt@inria.fr \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).