Hello Rich, On Thu, 11 Jan 2018 13:55:34 -0500 Rich Felker wrote: > Yes, there is a good deal of stuff in that file that, in hindsight, I > would do somewhat differently. A few of the worst things you noted > could be 'fixed' trivially with gotos No, I don't think this is necessary. I don't mind jumping in the middle of an "if (0)" branch, as long as it is indented correcly :) > or compound statatements and > probably should be. I don't want a big patch for this file that's hard > to review/validate though; the return on time spent is just too small. > If anyone does want to push me on making improvements here, small > isolated/individual changes that can easily be seen to be correct are > the way to go. Just a patch for white space and indentation would be easy, I think. - have break at the end of case lines, not at the start - start a newline before else - ident according to musl's coding style As long as git diff --color-words shows nothing, this should be fine. I could such a patch, if you want. Replacing comma operators by compound statements would be a bit more work. We could delay that to when somebody touches that file for more serious reasons. Jens -- :: INRIA Nancy Grand Est ::: Camus ::::::: ICube/ICPS ::: :: ::::::::::::::: office Strasbourg : +33 368854536 :: :: :::::::::::::::::::::: gsm France : +33 651400183 :: :: ::::::::::::::: gsm international : +49 15737185122 :: :: http://icube-icps.unistra.fr/index.php/Jens_Gustedt ::