From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12359 Path: news.gmane.org!.POSTED!not-for-mail From: Jens Gustedt Newsgroups: gmane.linux.lib.musl.general Subject: Re: alternative form flag with zero octal value Date: Thu, 11 Jan 2018 20:36:23 +0100 Organization: inria.fr Message-ID: <20180111203623.77269b94@inria.fr> References: <20180111114305.GG1268@lucy.localdomain> <20180111020246.GG1627@brightrain.aerifal.cx> <20180111021750.GH1627@brightrain.aerifal.cx> <20180111091229.3482569b@inria.fr> <20180111185534.GI1627@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/rwv1=B=FfmSrUQqzN1nA51T"; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1515699283 30645 195.159.176.226 (11 Jan 2018 19:34:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 Jan 2018 19:34:43 +0000 (UTC) Cc: musl@lists.openwall.com Original-X-From: musl-return-12375-gllmg-musl=m.gmane.org@lists.openwall.com Thu Jan 11 20:34:39 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1eZicW-0007U4-2p for gllmg-musl@m.gmane.org; Thu, 11 Jan 2018 20:34:36 +0100 Original-Received: (qmail 24398 invoked by uid 550); 11 Jan 2018 19:36:37 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 24364 invoked from network); 11 Jan 2018 19:36:36 -0000 X-IronPort-AV: E=Sophos;i="5.46,346,1511823600"; d="scan'208";a="308692493" In-Reply-To: <20180111185534.GI1627@brightrain.aerifal.cx> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) X-Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAACRQTFRFERslNjAsLTE9Ok9wUk9TaUs8iWhSrYZkj42Rz6aD3sGZ Xref: news.gmane.org gmane.linux.lib.musl.general:12359 Archived-At: --Sig_/rwv1=B=FfmSrUQqzN1nA51T Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hello Rich, On Thu, 11 Jan 2018 13:55:34 -0500 Rich Felker wrote: > Yes, there is a good deal of stuff in that file that, in hindsight, I > would do somewhat differently. A few of the worst things you noted > could be 'fixed' trivially with gotos No, I don't think this is necessary. I don't mind jumping in the middle of an "if (0)" branch, as long as it is indented correcly :) > or compound statatements and > probably should be. I don't want a big patch for this file that's hard > to review/validate though; the return on time spent is just too small. > If anyone does want to push me on making improvements here, small > isolated/individual changes that can easily be seen to be correct are > the way to go. Just a patch for white space and indentation would be easy, I think. - have break at the end of case lines, not at the start - start a newline before else - ident according to musl's coding style As long as git diff --color-words shows nothing, this should be fine. I could such a patch, if you want. Replacing comma operators by compound statements would be a bit more work. We could delay that to when somebody touches that file for more serious reasons. Jens --=20 :: INRIA Nancy Grand Est ::: Camus ::::::: ICube/ICPS ::: :: ::::::::::::::: office Strasbourg : +33 368854536 :: :: :::::::::::::::::::::: gsm France : +33 651400183 :: :: ::::::::::::::: gsm international : +49 15737185122 :: :: http://icube-icps.unistra.fr/index.php/Jens_Gustedt :: --Sig_/rwv1=B=FfmSrUQqzN1nA51T Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSN9stI2OFN1pLljN0P0+hp2tU34gUCWle8twAKCRAP0+hp2tU3 4vwkAJ0XHkXQQP3HsOnjqyGPmZRUWfxWNwCgk3XeoLjj/LSYCDgfzIe4p/WTIwA= =fKkS -----END PGP SIGNATURE----- --Sig_/rwv1=B=FfmSrUQqzN1nA51T--