From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12443 Path: news.gmane.org!.POSTED!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] aarch64: signal: fix type definition for ucontext_t.uc_link Date: Thu, 1 Feb 2018 10:51:06 +0100 Message-ID: <20180201095105.GN4418@port70.net> References: <20180131232924.4051-1-nenolod@dereferenced.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1517478583 18295 195.159.176.226 (1 Feb 2018 09:49:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Feb 2018 09:49:43 +0000 (UTC) User-Agent: Mutt/1.9.1 (2017-09-22) Cc: William Pitcock To: musl@lists.openwall.com Original-X-From: musl-return-12459-gllmg-musl=m.gmane.org@lists.openwall.com Thu Feb 01 10:49:39 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1ehBUa-00034p-Ua for gllmg-musl@m.gmane.org; Thu, 01 Feb 2018 10:49:17 +0100 Original-Received: (qmail 26084 invoked by uid 550); 1 Feb 2018 09:51:18 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 26064 invoked from network); 1 Feb 2018 09:51:17 -0000 Mail-Followup-To: musl@lists.openwall.com, William Pitcock Content-Disposition: inline In-Reply-To: <20180131232924.4051-1-nenolod@dereferenced.org> Xref: news.gmane.org gmane.linux.lib.musl.general:12443 Archived-At: * William Pitcock [2018-01-31 23:29:24 +0000]: > When compiling the test program for libucontext, I observed a compiler warning > concerning assignment to the wrong type (`struct __ucontext` vs `struct ucontext`). > Accordingly, ucontext_t.uc_link should be the same structure as ucontext_t itself. > --- > arch/aarch64/bits/signal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/aarch64/bits/signal.h b/arch/aarch64/bits/signal.h > index 5eb3d91f..1c67313d 100644 > --- a/arch/aarch64/bits/signal.h > +++ b/arch/aarch64/bits/signal.h > @@ -59,7 +59,7 @@ struct sigaltstack { > > typedef struct __ucontext { > unsigned long uc_flags; > - struct ucontext *uc_link; > + struct __ucontext *uc_link; yes this is a bug (it was introduced because originally the glibc name was copied for abi compat, then it was fixed to be namespace clean, but the field was not updated, meanwhile glibc broke its c++ abi to fix the namespace issue differently so we will have no abi compat..). thanks > stack_t uc_stack; > sigset_t uc_sigmask; > mcontext_t uc_mcontext; > -- > 2.16.1