From: Markus Wichmann <nullplan@gmx.net>
To: musl@lists.openwall.com
Subject: Re: fwrite() - possible division by zero
Date: Wed, 14 Feb 2018 21:07:07 +0100 [thread overview]
Message-ID: <20180214200707.hvbwbn733gwvtkbq@voyager> (raw)
In-Reply-To: <CACJ51z2V+UCu5ZwKhJfty_HAwTVvEipYyQHHN181a+wg03er7Q@mail.gmail.com>
On Wed, Feb 14, 2018 at 02:48:14PM -0500, Andrew Bell wrote:
> Why not early return if size == 0 and avoid the call to __fwritex
> altogether?
>
Because it's a rare corner case? Here, there's also locking correctness
to consider: fwrite() has to block until f is unlocked, irrespective of
parameters. So there's no real benefit to doing an early return.
Ciao,
Markus
next prev parent reply other threads:[~2018-02-14 20:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 18:24 Geraldo Netto
2018-02-14 19:39 ` Markus Wichmann
2018-02-14 19:48 ` Andrew Bell
2018-02-14 20:07 ` Markus Wichmann [this message]
2018-02-14 20:11 ` Andrew Bell
2018-02-14 21:15 ` Szabolcs Nagy
2018-02-14 21:47 ` Andrew Bell
2018-02-15 4:20 ` Rich Felker
2018-02-16 2:58 ` Geraldo Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214200707.hvbwbn733gwvtkbq@voyager \
--to=nullplan@gmx.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).