From: Natanael Copa <ncopa@alpinelinux.org>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [PATCH] strptime: Add %F format (glibc extension).
Date: Fri, 23 Feb 2018 11:56:52 +0100 [thread overview]
Message-ID: <20180223115652.5eb117e2@ncopa-desktop.copa.dup.pw> (raw)
In-Reply-To: <20180222234441.GG1436@brightrain.aerifal.cx>
On Thu, 22 Feb 2018 18:44:41 -0500
Rich Felker <dalias@libc.org> wrote:
> On Thu, Feb 22, 2018 at 10:53:39PM +0100, Przemyslaw Pawelczyk wrote:
> > %F is a shortcut for %Y-%m-%d, the ISO 8601 date format.
> > It's already present in POSIX's strftime(), so it makes sense to support
> > it in a converse function too.
> > ---
> >
> > I'm not subscribed to ML, so please CC me in case of replying.
> >
> > src/time/strptime.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/src/time/strptime.c b/src/time/strptime.c
> > index c54a0d8c4c52..2c0d45574819 100644
> > --- a/src/time/strptime.c
> > +++ b/src/time/strptime.c
> > @@ -59,6 +59,10 @@ char *strptime(const char *restrict s, const char *restrict f, struct tm *restri
> > s = strptime(s, "%m/%d/%y", tm);
> > if (!s) return 0;
> > break;
> > + case 'F':
> > + s = strptime(s, "%Y-%m-%d", tm);
> > + if (!s) return 0;
> > + break;
> > case 'H':
> > dest = &tm->tm_hour;
> > min = 0;
>
> Not having looked at this function in a while, I was doubtful the
> above would work, but in fact it looks like it does (analogous to the
> above case). While lots of this function is underspecified, the
> contract for the return value is well-designed.
>
> The want_century logic may be incomplete for %D and now %F, though. If
> so that's a separate issue from lack of %F extension and should be
> fixed in a separate patch. I think %F just needs to set want_century
> to 0, but %D might have more work to do.
>
> Rich
FWIW, '%F' is mentioned here:
http://austingroupbugs.net/view.php?id=879
<tt>F</tt> This specifier is similar to <tt>%Y-%m-%d</tt> where the
characters up to the first <hyphen-minus> separator shall be converted
as for %Y but with unlimited field width, the characters between the
two <hyphen-minus> separators shall be converted as for %m, and the
characters after the last <hyphen-minus> separator shall be converted
as for %d. If a field width is specified, each of the %Y, %m, and %d
conversions shall not convert any characters past the overall %F field
width.
-nc
prev parent reply other threads:[~2018-02-23 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 21:53 Przemyslaw Pawelczyk
2018-02-22 23:44 ` Rich Felker
2018-02-23 10:56 ` Natanael Copa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223115652.5eb117e2@ncopa-desktop.copa.dup.pw \
--to=ncopa@alpinelinux.org \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).