From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Maybe not a bug but a possible omission?
Date: Wed, 28 Mar 2018 13:54:25 -0400 [thread overview]
Message-ID: <20180328175425.GN1436@brightrain.aerifal.cx> (raw)
In-Reply-To: <20180328171948.GC4418@port70.net>
On Wed, Mar 28, 2018 at 07:19:49PM +0200, Szabolcs Nagy wrote:
> * Jon Scobie <jon.scobie@callsign.com> [2018-03-28 14:33:23 +0100]:
> > Well, I definitely agree that instead of definitions like
> >
> > #define INT64_MIN (-1-0x7fffffffffffffff)
> >
> > we should have
> >
> > #define INT64_MIN (-1 - INT64_C(0x7fffffffffffffff))
> >
>
> why?
>
> "The macro INTN_C(value) shall expand to an integer constant expression corresponding to the type int_leastN_t"
>
> i dont think it is necessary or appropriate: the c rules
> already handles this portably: the const has the lowest
> rank 64bit signed int type, any additional complication
> can just get the type wrong.
Yes. If a tool is misinterpreting the expressions here, the tool
should be fixed. They all have the intended types already when
evaluated as C expressions. Making random edits to headers to make
buggy tools happy is not a direction I want to take.
Rich
next prev parent reply other threads:[~2018-03-28 17:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 10:31 Jon Scobie
2018-03-28 12:52 ` CodingMarkus
2018-03-28 13:33 ` Jon Scobie
2018-03-28 17:19 ` Szabolcs Nagy
2018-03-28 17:54 ` Rich Felker [this message]
2018-03-29 0:30 ` Jon Scobie
2018-03-29 4:53 ` Markus Wichmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328175425.GN1436@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).