From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: catan errors
Date: Tue, 10 Apr 2018 16:50:32 -0400 [thread overview]
Message-ID: <20180410205032.GL3094@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAFdMc-1LroYkRHM7wfYSc_CAE8DwjShO=cz0wdcfa=b=AVyn6g@mail.gmail.com>
On Tue, Apr 10, 2018 at 05:41:46PM -0300, dgutson . wrote:
> On Tue, Apr 10, 2018 at 5:32 PM, Rich Felker <dalias@libc.org> wrote:
>
> > On Tue, Apr 10, 2018 at 05:23:12PM -0300, dgutson . wrote:
> > > On Tue, Apr 10, 2018 at 4:50 PM, Rich Felker <dalias@libc.org> wrote:
> > >
> > > > The OpenBSD catan implementation we're using has a number of
> > > > nonsensical "overflow" (goto ovrf) conditions that aren't errors,
> > > > reported by mepholic on irc. I think the attached patch fixes them
> > > > without introducing new problems, but I'm not sure if any other
> > > > problems remain.
> > > >
> > > > Note that, of the three cases removed:
> > > >
> > > > 1. Is not an exceptional case at all, and made no sense to begin with..
> > > >
> > > > 2. Is only exceptional if x and a are both zero; atan(2x,0) is
> > > > perfectly well-defined.
> > > >
> > > > 3. Is only possible if y==1.0 and x==0.0, which is the only real
> > > > exceptional case for atan: z==I.
> > > >
> > >
> > >
> > > Besides the trigonometric case, are you considering de-normalized
> > numbers,
> > > such as 4.94066e-324 as divisor?
> > > For example:
> > > double x = 1.0;
> > > double y = 5E-324;
> > > x / y is inf, and y != 0.0.
> > > Shouldn't 'a' be checked against that number or its absolute value >=
> > > minimum?
> >
> > Can you clarify where you think something goes wrong?
> >
>
> - if (a == 0.0)
> - goto ovrf;
>
> t = y + 1.0;
> a = (x2 + t * t)/a;
>
>
> The check you removed does not look correct for me because what I mentioned..
> However, shouldn't you check, before the division, that a is not the
> nearest to zero (+ or -) denormalized representable double,
> in order to avoid ending in inf?
Here a=x²+(y-1)², so unless both x==0 and y==1, the smallest a can be
is DBL_EPSILON². When a is small, the numerator in the last line is
also small (x²+(1+y)² < 2) so dividing by a does not overflow.
Rich
next prev parent reply other threads:[~2018-04-10 20:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 19:50 Rich Felker
2018-04-10 20:23 ` dgutson .
2018-04-10 20:32 ` Rich Felker
2018-04-10 20:41 ` dgutson .
2018-04-10 20:50 ` Rich Felker [this message]
2018-04-10 21:27 ` dgutson .
2018-04-10 22:14 ` Rich Felker
2018-04-10 23:08 ` Szabolcs Nagy
2018-04-10 23:23 ` Rich Felker
2018-04-11 0:52 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410205032.GL3094@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).