From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: tcmalloc compatibility
Date: Thu, 19 Apr 2018 15:11:52 -0400 [thread overview]
Message-ID: <20180419191152.GM3094@brightrain.aerifal.cx> (raw)
In-Reply-To: <20180419182743.GP4418@port70.net>
On Thu, Apr 19, 2018 at 08:27:44PM +0200, Szabolcs Nagy wrote:
> * Rich Felker <dalias@libc.org> [2018-04-18 16:35:56 -0400]:
> > Today I pushed changes which should make malloc
> > replacement/interposition work reliably as long as you only use
> > AS-safe functions. If you try this, please let us know how it turns
> > out and if you run into any unexpected problems.
>
> there was a report on irc that this change in memalign has falsepositives:
>
> - if (len > SIZE_MAX - align) {
> + if (len > SIZE_MAX - align || free != __internal_free) {
>
> in particular &free can point to a plt entry in the main executable
> while &__internal_free is in libc.so so they compare unequal.
Indeed, this will need to be reworked. I'll probably remove these
checks for now so that git master is not broken.
Rich
next prev parent reply other threads:[~2018-04-19 19:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 10:22 Denis V. Razumovsky
2018-04-10 14:33 ` Rich Felker
2018-04-10 14:45 ` Bobby Powers
2018-04-10 15:35 ` Rich Felker
[not found] ` <878t9vlzh1.fsf@mid.deneb.enyo.de>
2018-04-10 18:39 ` Rich Felker
2018-04-10 20:33 ` Szabolcs Nagy
2018-04-10 20:44 ` Rich Felker
2018-04-10 21:17 ` Szabolcs Nagy
2018-04-15 11:52 ` ardi
2018-04-16 4:19 ` Markus Wichmann
2018-04-16 4:40 ` Rich Felker
2018-04-18 20:35 ` Rich Felker
2018-04-19 18:27 ` Szabolcs Nagy
2018-04-19 19:11 ` Rich Felker [this message]
2018-04-18 20:50 ` Florian Weimer
2018-04-18 21:06 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419191152.GM3094@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).