From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12746 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: tcmalloc compatibility Date: Thu, 19 Apr 2018 15:11:52 -0400 Message-ID: <20180419191152.GM3094@brightrain.aerifal.cx> References: <20180410143359.GF3094@brightrain.aerifal.cx> <878t9vlzh1.fsf@mid.deneb.enyo.de> <20180410203354.GI4418@port70.net> <20180410204411.GK3094@brightrain.aerifal.cx> <20180410211724.GJ4418@port70.net> <20180416041924.GA23767@voyager> <20180416044006.GY3094@brightrain.aerifal.cx> <20180418203556.GH3094@brightrain.aerifal.cx> <20180419182743.GP4418@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1524165002 22204 195.159.176.226 (19 Apr 2018 19:10:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 19 Apr 2018 19:10:02 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-12762-gllmg-musl=m.gmane.org@lists.openwall.com Thu Apr 19 21:09:58 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1f9EwO-0005dh-Vr for gllmg-musl@m.gmane.org; Thu, 19 Apr 2018 21:09:57 +0200 Original-Received: (qmail 15974 invoked by uid 550); 19 Apr 2018 19:12:05 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 15954 invoked from network); 19 Apr 2018 19:12:04 -0000 Content-Disposition: inline In-Reply-To: <20180419182743.GP4418@port70.net> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:12746 Archived-At: On Thu, Apr 19, 2018 at 08:27:44PM +0200, Szabolcs Nagy wrote: > * Rich Felker [2018-04-18 16:35:56 -0400]: > > Today I pushed changes which should make malloc > > replacement/interposition work reliably as long as you only use > > AS-safe functions. If you try this, please let us know how it turns > > out and if you run into any unexpected problems. > > there was a report on irc that this change in memalign has falsepositives: > > - if (len > SIZE_MAX - align) { > + if (len > SIZE_MAX - align || free != __internal_free) { > > in particular &free can point to a plt entry in the main executable > while &__internal_free is in libc.so so they compare unequal. Indeed, this will need to be reworked. I'll probably remove these checks for now so that git master is not broken. Rich